Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M2354: Substitute HIRC for HXT to clock PLL #14739

Merged
merged 3 commits into from
Jun 7, 2021

Conversation

ccli8
Copy link
Contributor

@ccli8 ccli8 commented Jun 7, 2021

Summary of changes

This PR tries to substitute HIRC for HXT to clock PLL. This is to spare one external crystal oscillator HXT. Below list the modifications:

  1. Build TF-M secure code with HXT not present, replaced with HIRC.
  2. Required to be consistent with above, on Mbed, HXT defaults to not present.
  3. Synchronize platform extra secure files from TF-M. This makes no logic change on Mbed.
  4. Refine TF-M import readme.

Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

ccli8 added 3 commits June 4, 2021 10:32
Add bug report of GNU Arm Embedded Toolchain 10-2020-q4-major in CMSE support
These files are refactored on TF-M and make no logic change on Mbed.
1.  Build TF-M v1.3 with GNUARM and HXT not present.
2.  Support configurability of HXT presence (targets.json).
3.  Default HXT to not present (targets.json). This must align with built TF-M secure code above.
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Jun 7, 2021
@ciarmcom
Copy link
Member

ciarmcom commented Jun 7, 2021

@ccli8, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@@ -75,7 +75,7 @@ To define memory spec of SRAM for TF-M/Mbed, search/change the line:
Navigate [TF-M](https://www.trustedfirmware.org/projects/tf-m/).
Then go through **DOCS** → **Getting Started Guides** → **Software requirements** for TF-M build environment setup.

**NOTE**: For unknown reason, **GNU Arm Embedded Toolchain 10-2020-q4-major** built code **FAILS** to run. Avoid this toolchain version.
**NOTE**: **GNU Arm Embedded Toolchain 10-2020-q4-major** built code **FAILS** to run. Avoid this toolchain version. Check [its bug report](https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99157).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its fixed now so the next version will have it fixed as well

@mergify mergify bot added needs: CI and removed needs: review labels Jun 7, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 7, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Jun 7, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit a83ec19 into ARMmbed:master Jun 7, 2021
@mergify mergify bot removed the ready for merge label Jun 7, 2021
@ccli8 ccli8 deleted the nuvoton_m2354_tfm_no_hxt branch June 8, 2021 01:08
@mbedmain mbedmain added release-version: 6.12.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants