STM32 TRNG: update init to match all configs #14722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jeromecoutant, thank you for your changes. |
0xc0170
previously requested changes
Jun 2, 2021
targets/TARGET_STM/trng_api.c
Outdated
| if (HAL_RNG_GenerateRandomNumber(&obj->handle, &dummy) != HAL_OK) { | ||
| printf("trng_init: HAL_RNG_GenerateRandomNumber error 0x%x\n", obj->handle.ErrorCode); // should not occur | ||
| while (HAL_RNG_GenerateRandomNumber(&obj->handle, &dummy) != HAL_OK) { | ||
| // printf("trng_init: HAL_RNG_GenerateRandomNumber error 0x%x\n", obj->handle.ErrorCode); |
There was a problem hiding this comment.
Either remove or propagate the error
There was a problem hiding this comment.
The comment should be updated as the while changes it a bit - we are waiting until we get a number
There was a problem hiding this comment.
@0xc0170 done
0xc0170
approved these changes
Jun 2, 2021
|
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
After more tests and discussions with experts, patch done in #14687 is removed,
and replaced by a better init procedure that matches all cases and chips.
@JeanMarcR
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers