CMake: Only force Ninja response files on Windows #14656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We force Ninja to create response files to work around file path length limitations on Windows. Previously we were forcing the response file generation for all platforms, unless we were building on Windows using ARMClang, this was to work around a CMake issue https://gitlab.kitware.com/cmake/cmake/-/issues/21093 Unfortunately `ar` on macOS doesn't support Ninja response files. So the check was incorrect, as forcing a response file to be generated on macOS causes a build failure when trying to build Mbed's unit tests. This PR changes the logic so we only generate a response file on Windows systems if we're not building with ARMClang.
0xc0170
approved these changes
May 11, 2021
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
|
The initial aim was to have the same behavior on all platforms and exclude the problematic one (if fixed, we can remove the exclusion). As we can see, response files have more issues unfortunately. The |
0xc0170
added
the
release-type: patch
mbedmain
removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
We force Ninja to create response files to work around file path length
limitations on Windows. Previously we were forcing the response file
generation for all platforms, unless we were building on Windows using
ARMClang, this was to work around a CMake issue
https://gitlab.kitware.com/cmake/cmake/-/issues/21093
Unfortunately
aron macOS doesn't support Ninja response files. So thecheck was incorrect, as forcing a response file to be generated on macOS
causes a build failure when trying to build Mbed's unit tests.
This PR changes the logic so we only generate a response file on Windows
systems if we're not building with ARMClang.
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers