Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requirements: Relax Click version requirement #14653

Merged
merged 1 commit into from
May 10, 2021

Conversation

rwalton-arm
Copy link
Contributor

Summary of changes

We were pinning the version of Click to 7.0.~. This was preventing
side-by-side installs with mbed-tools, as mbed-tools requires
Click>=7.1,<8.

Relax the Click version requirement to >7.0,<8 to prevent dependency
conflicts with mbed-tools.

Impact of changes

Migration actions required

Documentation

None

Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


We were pinning the version of Click to 7.0.~. This was preventing
side-by-side installs with mbed-tools, as mbed-tools requires
Click>=7.1,<8.

Relax the Click version requirement to >7.0,<8 to prevent dependency
conflicts with mbed-tools.
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label May 10, 2021
@ciarmcom ciarmcom requested a review from a team May 10, 2021 11:00
@ciarmcom
Copy link
Member

@rwalton-arm, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot added needs: CI and removed needs: review labels May 10, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented May 10, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented May 10, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 4eff89c into ARMmbed:master May 10, 2021
@mergify mergify bot removed the ready for merge label May 10, 2021
@mbedmain mbedmain removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants