Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPC15xx extended CAN fix (5.15) #14597

Merged
merged 1 commit into from
Jun 15, 2021
Merged

LPC15xx extended CAN fix (5.15) #14597

merged 1 commit into from
Jun 15, 2021

Conversation

jetremblay
Copy link

Summary of changes

This PR fixes an issue with parsing the identifier of received extended CAN frames on the LPC15xx targets. According to the user manual, CANIF2_ARB2 contains the high bits while CANIF2_ARB1 contains the low bits of the extended CAN identifier.

Impact of changes

Migration actions required

Documentation

None

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ciarmcom ciarmcom requested a review from a team April 27, 2021 02:00
@ciarmcom
Copy link
Member

@jetremblay, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 requested a review from andypowers April 27, 2021 12:39
@mergify mergify bot added needs: CI and removed needs: review labels Apr 27, 2021
@ciarmcom ciarmcom added the stale Stale Pull Request label May 10, 2021
@ciarmcom
Copy link
Member

This pull request has automatically been marked as stale because it has had no recent activity. @ARMmbed/mbed-os-maintainers, please start CI to get the PR merged.

andypowers
andypowers approved these changes May 13, 2021
View reviewed changes
Copy link
Collaborator

@andypowers andypowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@ciarmcom ciarmcom added stale Stale Pull Request and removed stale Stale Pull Request labels May 14, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented May 18, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented May 18, 2021

Test run: FAILED

Summary: 1 of 10 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_example-test-lts

@mergify mergify bot added needs: work and removed needs: CI labels May 18, 2021
@ciarmcom ciarmcom removed the stale Stale Pull Request label May 18, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented May 19, 2021

CI restarted

@mbed-ci
Copy link

mbed-ci commented May 19, 2021

Test run: FAILED

Summary: 1 of 10 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_example-test-lts

@mergify mergify bot added needs: work and removed needs: CI labels May 19, 2021
@mbed-ci
Copy link

mbed-ci commented May 21, 2021

Test run: FAILED

Summary: 1 of 10 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_example-test-lts

@mergify mergify bot added needs: work and removed needs: CI labels May 21, 2021
@ciarmcom ciarmcom added the stale Stale Pull Request label Jun 2, 2021
@ciarmcom
Copy link
Member

ciarmcom commented Jun 2, 2021

This pull request has automatically been marked as stale because it has had no recent activity. @jetremblay, please carry out any necessary work to get the changes merged. Thank you for your contributions.

@ciarmcom ciarmcom removed the stale Stale Pull Request label Jun 4, 2021
@jetremblay
Copy link
Author

The failed test is related to another platform (K64F). I am not sure what to do for this?

@ciarmcom ciarmcom added the stale Stale Pull Request label Jun 6, 2021
@0xc0170 0xc0170 added needs: CI and removed needs: work stale Stale Pull Request labels Jun 7, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 7, 2021

The failed test is related to another platform (K64F). I am not sure what to do for this?

Correct, it should be restarted.

CI restarted

@mbed-ci
Copy link

mbed-ci commented Jun 7, 2021

Test run: FAILED

Summary: 1 of 10 test jobs failed
Build number : 4
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_example-test-lts

@mergify mergify bot added needs: work and removed needs: CI labels Jun 7, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 10, 2021

CI restarted

@ciarmcom ciarmcom added the stale Stale Pull Request label Jun 11, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 11, 2021

I run the job on incorrect CI instance, I'll need to restart

@ciarmcom ciarmcom added stale Stale Pull Request and removed stale Stale Pull Request labels Jun 11, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 14, 2021

Ci started

@mbed-ci
Copy link

mbed-ci commented Jun 14, 2021

Test run: SUCCESS

Summary: 10 of 10 test jobs passed
Build number : 5
Build artifacts

@0xc0170 0xc0170 removed the stale Stale Pull Request label Jun 15, 2021
@0xc0170 0xc0170 merged commit bfe3d50 into ARMmbed:mbed-os-5.15 Jun 15, 2021
@mergify mergify bot removed the ready for merge label Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@andypowers andypowers andypowers approved these changes

Assignees
No one assigned
Labels
release-version: 5.15.8
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jetremblay @ciarmcom @0xc0170 @mbed-ci @andypowers