Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mbed-os-5.15: Mesh api: Added PHY mode, channel plan IDs and configuration functions #14566

Merged
merged 3 commits into from
Jun 24, 2021
Merged

mbed-os-5.15: Mesh api: Added PHY mode, channel plan IDs and configuration functions #14566

merged 3 commits into from
Jun 24, 2021

Conversation

artokin
Copy link
Contributor

@artokin artokin commented Apr 20, 2021 •
edited
Loading

Summary of changes

Support for Wi-SUN FAN v1.1 PHY mode ID and channel plan ID in Mesh API.

Implemented domain configuration functions in mesh API:

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@mikter @mikaleppanen @artokin @juhhei01

mikter
mikter previously approved these changes Apr 20, 2021
View reviewed changes
@mergify mergify bot dismissed mikter’s stale review April 20, 2021 09:31

Pull request has been modified.

@artokin artokin changed the title [mbed-os-5.15] Mesh api: Added PHY mode and channel plan IDs [mbed-os-5.15] Mesh api: Added PHY mode, channel plan IDs and configuration functions Apr 20, 2021
@mergify mergify bot added the needs: work label Apr 20, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 20, 2021

@artokin Please review events failures, look related

@artokin
Copy link
Contributor Author

artokin commented Apr 20, 2021

This PR requires preceding PR #14565 in order to compile.

@ciarmcom ciarmcom added the stale Stale Pull Request label May 10, 2021
@ciarmcom
Copy link
Member

This pull request has automatically been marked as stale because it has had no recent activity. @artokin, please carry out any necessary work to get the changes merged. Thank you for your contributions.

@ciarmcom ciarmcom added stale Stale Pull Request and removed stale Stale Pull Request labels May 14, 2021
@artokin artokin force-pushed the phy_mode_and_channel_plan_5_15 branch from aea6a5d to 9e6ee26 Compare May 19, 2021 06:16
@artokin artokin requested a review from JarkkoPaso May 19, 2021 06:17
@artokin
Copy link
Contributor Author

artokin commented May 19, 2021

Rebased on top of mbed-os-5.15 that now contains the PR #14565.

@ciarmcom ciarmcom removed the stale Stale Pull Request label May 19, 2021
@0xc0170 0xc0170 requested a review from andypowers May 19, 2021 09:41
@ciarmcom ciarmcom added the stale Stale Pull Request label May 20, 2021
@ciarmcom ciarmcom removed the stale Stale Pull Request label Jun 10, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 10, 2021

Ci restarted

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 10, 2021

We removed mbed-os-example-tls-socket as it was deprecated some time ago.

@mbed-ci
Copy link

mbed-ci commented Jun 10, 2021

Test run: SUCCESS

Summary: 10 of 10 test jobs passed
Build number : 2
Build artifacts

@ciarmcom ciarmcom added the stale Stale Pull Request label Jun 15, 2021
@ciarmcom
Copy link
Member

This pull request has automatically been marked as stale because it has had no recent activity. @mikter, @andypowers, please complete review of the changes to move the PR forward. Thank you for your contributions.

@0xc0170 0xc0170 removed Release review required stale Stale Pull Request labels Jun 16, 2021
@ciarmcom ciarmcom added stale Stale Pull Request and removed stale Stale Pull Request labels Jun 16, 2021
@0xc0170 0xc0170 added needs: CI and removed needs: review stale Stale Pull Request labels Jun 21, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 21, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Jun 21, 2021

Test run: SUCCESS

Summary: 10 of 10 test jobs passed
Build number : 3
Build artifacts

@0xc0170 0xc0170 changed the title [mbed-os-5.15] Mesh api: Added PHY mode, channel plan IDs and configuration functions mbed-os-5.15: Mesh api: Added PHY mode, channel plan IDs and configuration functions Jun 23, 2021
andypowers
andypowers approved these changes Jun 23, 2021
View reviewed changes
Copy link
Collaborator

@andypowers andypowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@0xc0170 0xc0170 merged commit ce84a0d into ARMmbed:mbed-os-5.15 Jun 24, 2021
@mergify mergify bot removed the ready for merge label Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@juhhei01 juhhei01 juhhei01 approved these changes

@JarkkoPaso JarkkoPaso JarkkoPaso approved these changes

@mikaleppanen mikaleppanen mikaleppanen approved these changes

@andypowers andypowers andypowers approved these changes

@mikter mikter Awaiting requested review from mikter

Assignees
No one assigned
Labels
release-version: 5.15.8
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@artokin @0xc0170 @ciarmcom @mbed-ci @juhhei01 @JarkkoPaso @mikter @mikaleppanen @andypowers