Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mbed-os-5.15: Add API to reset MAC statistics and Wi-SUN statistics #14552

Merged
merged 1 commit into from
Jun 24, 2021
Merged

mbed-os-5.15: Add API to reset MAC statistics and Wi-SUN statistics #14552

merged 1 commit into from
Jun 24, 2021

Conversation

debdeep-arm
Copy link
Contributor

@debdeep-arm debdeep-arm commented Apr 15, 2021 •
edited
Loading

Summary of changes

Added API to reset MAC statistics and Wi-SUN statistics.
This is copied from #14439

Impact of changes

None

Migration actions required

None

Documentation

None

Pull request type 

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[X] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@artokin

@ciarmcom ciarmcom requested review from artokin and a team April 15, 2021 13:00
@ciarmcom
Copy link
Member

@debdeep-arm, thank you for your changes.
@artokin @ARMmbed/mbed-os-maintainers please review.

artokin
artokin previously approved these changes Apr 20, 2021
View reviewed changes
@mergify mergify bot added needs: CI and removed needs: review labels Apr 20, 2021
mikter
mikter previously approved these changes Apr 20, 2021
View reviewed changes
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 26, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 26, 2021

Test run: SUCCESS

Summary: 10 of 10 test jobs passed
Build number : 1
Build artifacts

@adbridge
Copy link
Contributor

@debdeep-arm this is a feature update and as such you should fill in :
Impact of changes
Migration actions required

Also is there any updates to documentation required? If so that should also be noted in the Documentation section.
Please update asap.

@debdeep-arm
Copy link
Contributor Author

@debdeep-arm this is a feature update and as such you should fill in :
Impact of changes
Migration actions required

Also is there any updates to documentation required? If so that should also be noted in the Documentation section.
Please update asap.

Hi @adbridge,
The impact of changes is none. And also Migration is not required as per my understanding.
@mikaleppanen and @artokin can comment on this.
I will fill in these fields accordingly.
Also @artokin @mikaleppanen do I need to update any document ?

@artokin
Copy link
Contributor

artokin commented May 14, 2021

No need for document updates. This new API is documented like the previous ones.

@0xc0170 0xc0170 changed the title [mbed-os-5.15] Added API to reset MAC statistics and Wi-SUN statistics mbed-os-5.15: Add API to reset MAC statistics and Wi-SUN statistics May 18, 2021
@0xc0170 0xc0170 requested a review from andypowers May 18, 2021 14:54
@0xc0170
Copy link
Contributor

0xc0170 commented May 21, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented May 21, 2021

Test run: FAILED

Summary: 1 of 10 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_example-test-lts

@debdeep-arm
Copy link
Contributor Author

Rebased.

@mergify mergify bot dismissed stale reviews from artokin and mikter May 26, 2021 12:40

Pull request has been modified.

@ciarmcom ciarmcom added the stale Stale Pull Request label Jun 7, 2021
@ciarmcom
Copy link
Member

ciarmcom commented Jun 7, 2021

This pull request has automatically been marked as stale because it has had no recent activity. @debdeep-arm, please carry out any necessary work to get the changes merged. Thank you for your contributions.

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 7, 2021

I'll start CI soon

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 7, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Jun 7, 2021

Test run: FAILED

Summary: 1 of 10 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_example-test-lts

@mergify mergify bot added needs: work and removed needs: CI labels Jun 7, 2021
@debdeep-arm
Copy link
Contributor Author

What went wrong here ?
I could not find any issue due to the changes of this PR.

@ciarmcom ciarmcom added stale Stale Pull Request and removed stale Stale Pull Request labels Jun 17, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 21, 2021

CI restarted

@mbed-ci
Copy link

mbed-ci commented Jun 21, 2021

Test run: SUCCESS

Summary: 10 of 10 test jobs passed
Build number : 4
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: work stale Stale Pull Request labels Jun 23, 2021
andypowers
andypowers approved these changes Jun 23, 2021
View reviewed changes
Copy link
Collaborator

@andypowers andypowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@0xc0170 0xc0170 merged commit e48b7b9 into ARMmbed:mbed-os-5.15 Jun 24, 2021
@mergify mergify bot removed the ready for merge label Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@mikaleppanen mikaleppanen mikaleppanen approved these changes

@andypowers andypowers andypowers approved these changes

@mikter mikter mikter left review comments

@artokin artokin artokin left review comments

@JarkkoPaso JarkkoPaso Awaiting requested review from JarkkoPaso

@juhhei01 juhhei01 Awaiting requested review from juhhei01

Assignees
No one assigned
Labels
release-version: 5.15.8
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@debdeep-arm @ciarmcom @0xc0170 @mbed-ci @adbridge @artokin @mikter @mikaleppanen @andypowers