Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

M487: Adjust placement of SYS_UnlockReg in WDT reset code #14524

Merged
merged 1 commit into from
Apr 12, 2021
Merged

M487: Adjust placement of SYS_UnlockReg in WDT reset code #14524

merged 1 commit into from
Apr 12, 2021

Conversation

ccli8
Copy link
Contributor

@ccli8 ccli8 commented Apr 9, 2021

Summary of changes

This PR tries to adjust placement of SYS_UnlockReg in WDT reset code for:

  1. Avoiding misleading placement of SYS_UnlockReg for WDT clock setting
  2. Safer for power-down

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

@ccli8
M487: Adjust placement of SYS_UnlockReg in WDT reset from PD patch
df4f1a3 
This adjustment has two purposes:
1.  Avoid misleading placement of SYS_UnlockReg for WDT clock setting
2.  Safer for power-down
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Apr 9, 2021
@ciarmcom ciarmcom requested a review from a team April 9, 2021 03:00
@ciarmcom
Copy link
Member

ciarmcom commented Apr 9, 2021

@ccli8, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ccli8 ccli8 mentioned this pull request Apr 9, 2021
Merged
@mergify mergify bot added needs: CI and removed needs: review labels Apr 9, 2021
@mbed-ci
Copy link

mbed-ci commented Apr 12, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️

@0xc0170 0xc0170 merged commit 1aa38b4 into ARMmbed:master Apr 12, 2021
@mergify mergify bot removed the ready for merge label Apr 12, 2021
@mbedmain mbedmain removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
devices: nuvoton release-version: 6.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ccli8 @ciarmcom @mbed-ci @0xc0170 @mbedmain