Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mbed-os-5.15: Added new start methods to Wi-SUN BR with WisunInterface parameter and deprecated the old ones #14464

Merged
merged 1 commit into from
Jun 21, 2021
Merged

mbed-os-5.15: Added new start methods to Wi-SUN BR with WisunInterface parameter and deprecated the old ones #14464

merged 1 commit into from
Jun 21, 2021

Conversation

mikaleppanen
Copy link

Summary of changes

Previously WisunBorderRouter start() used NetworkInterface type for mesh interface, although only WisunInterface type is possible for the call. Added a new overloads of the start with the WisunInterface as mesh interface type and deprecated the old ones. This makes the calls stricter about the interface type and safer. It also allows to remove the reinterpret_cast that causes
compiler warning on ARM compiler.

This is mbed-os-5.15 version of #14462

Impact of changes

None

Migration actions required

None

Documentation

None

Pull request type 

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@mikter @artokin

@ciarmcom ciarmcom requested review from artokin, mikter and a team March 24, 2021 12:00
@ciarmcom
Copy link
Member

@mikaleppanen, thank you for your changes.
@artokin @mikter @ARMmbed/mbed-os-maintainers please review.

Added new start methods to Wi-SUN BR with WisunInterface parameter an…
da29b80 
…d deprecated the old ones

Previously WisunBorderRouter start() used NetworkInterface type for mesh interface, although only
WisunInterface type is possible for the call. Added a new overloads of the start with the
WisunInterface as mesh interface type and deprecated the old ones. This makes the calls stricter
about the interface type and safer. It also allows to remove the reinterpret_cast that causes
compiler warning on ARM compiler.
@mergify mergify bot added needs: CI and removed needs: review labels Apr 7, 2021
@0xc0170 0xc0170 requested a review from andypowers April 26, 2021 12:01
@ciarmcom
Copy link
Member

This pull request has automatically been marked as stale because it has had no recent activity. @ARMmbed/mbed-os-maintainers, please start CI to get the PR merged.

@ciarmcom ciarmcom added the stale Stale Pull Request label May 10, 2021
andypowers
andypowers approved these changes May 13, 2021
View reviewed changes
Copy link
Collaborator

@andypowers andypowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@ciarmcom ciarmcom added stale Stale Pull Request and removed stale Stale Pull Request labels May 14, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented May 19, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented May 19, 2021

Test run: FAILED

Summary: 1 of 10 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_example-test-lts

@mergify mergify bot added needs: work and removed needs: CI labels May 19, 2021
@ciarmcom ciarmcom removed the stale Stale Pull Request label May 19, 2021
@mbed-ci
Copy link

mbed-ci commented May 21, 2021

Test run: FAILED

Summary: 1 of 10 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_example-test-lts

@ciarmcom ciarmcom added the stale Stale Pull Request label May 24, 2021
@adbridge
Copy link
Contributor

@mikaleppanen could you take a look at the test failures ?

@adbridge adbridge removed needs: CI stale Stale Pull Request labels May 25, 2021
@ciarmcom ciarmcom added the stale Stale Pull Request label Jun 4, 2021
@ciarmcom
Copy link
Member

ciarmcom commented Jun 4, 2021

This pull request has automatically been marked as stale because it has had no recent activity. @mikaleppanen, please carry out any necessary work to get the changes merged. Thank you for your contributions.

@ciarmcom ciarmcom added stale Stale Pull Request and removed stale Stale Pull Request labels Jun 4, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 7, 2021

I restarted tests to get the latest results

@0xc0170 0xc0170 added needs: CI and removed needs: work stale Stale Pull Request labels Jun 7, 2021
@mergify mergify bot added needs: work and removed needs: CI labels Jun 7, 2021
@mbed-ci
Copy link

mbed-ci commented Jun 7, 2021

Test run: FAILED

Summary: 1 of 10 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_example-test-lts

@ciarmcom ciarmcom added stale Stale Pull Request and removed stale Stale Pull Request labels Jun 17, 2021
@0xc0170 0xc0170 added needs: CI and removed needs: work stale Stale Pull Request labels Jun 21, 2021
@0xc0170 0xc0170 changed the title [mbed-os-5.15] Added new start methods to Wi-SUN BR with WisunInterface parameter and deprecated the old ones mbed-os-5.15: Added new start methods to Wi-SUN BR with WisunInterface parameter and deprecated the old ones Jun 21, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 21, 2021

CI restarted

@mbed-ci
Copy link

mbed-ci commented Jun 21, 2021

Test run: SUCCESS

Summary: 10 of 10 test jobs passed
Build number : 4
Build artifacts

@0xc0170 0xc0170 merged commit 32ecdb3 into ARMmbed:mbed-os-5.15 Jun 21, 2021
@mergify mergify bot removed the ready for merge label Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andypowers andypowers andypowers approved these changes

@artokin artokin artokin approved these changes

@mikter mikter mikter approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.15.8
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@mikaleppanen @ciarmcom @0xc0170 @mbed-ci @adbridge @mikter @artokin @andypowers