-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MXRT1050 Flash support #12317
MXRT1050 Flash support #12317
Conversation
@mmahadevan108, thank you for your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me. @ARMmbed/mbed-os-maintainers please review and run CI. thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approve
8a5567c
to
3052257
Compare
Pull request has been modified.
I made a small fix as I was seeing failures with the ARM toolchain. Now passing with all toolchains |
This PR cannot be merged due to conflicts. Please rebase to resolve them. |
These functions are used to READ/WRITE to the Flexspi NOR Signed-off-by: Mahesh Mahadevan <[email protected]>
3052257
to
f4e54d0
Compare
Rebased and updated PR |
f4e54d0
to
b7b02d0
Compare
I have added FLASHIAP support in this PR. Test results for FLASHIAP tests are given below:
|
Signed-off-by: Mahesh Mahadevan <[email protected]>
Reserve 4MB for mbed-os. The rest is used by storage driver Signed-off-by: Mahesh Mahadevan <[email protected]>
Signed-off-by: Mahesh Mahadevan <[email protected]>
b7b02d0
to
b5eb7bc
Compare
@@ -2441,7 +2441,7 @@ | |||
"TRNG", | |||
"FLASH", | |||
"WATCHDOG" | |||
], | |||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got confused initially, as there was another PR as well touching these spaces. I left the comment here.
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Requested by Tuomo for consideration for LTS branch. |
This went to a feature branch so assuming this will not go across to 5.15 proper. |
Summary of changes
Add Flash support for MXRT1050
Impact of changes
NONE
Migration actions required
NONE
Documentation
NONE
Pull request type
Test results
mbedgt: checking for GCOV data...
mbedgt: mbed-host-test-runner: stopped and returned 'OK'
mbedgt: test on hardware with target id: 0227000041114e45004f3003b60f0045a6e1000097969900
mbedgt: test suite 'mbed-os-tests-mbed_hal-flash' .................................................... OK in 15.39 sec
test case: 'Flash - clock and cache test' .................................................... OK in 0.10 sec
test case: 'Flash - erase sector' ............................................................ OK in 0.93 sec
test case: 'Flash - init' .................................................................... OK in 0.08 sec
test case: 'Flash - mapping alignment' ....................................................... OK in 0.07 sec
test case: 'Flash - program page' ............................................................ OK in 0.92 sec
mbedgt: test case summary: 5 passes, 0 failures
mbedgt: all tests finished!
mbedgt: shuffle seed: 0.4889306488
mbedgt: test suite report:
Reviewers
@maclobdell