Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MXRT1050 Flash support #12317

Merged
merged 4 commits into from
Feb 4, 2020
Merged

MXRT1050 Flash support #12317

merged 4 commits into from
Feb 4, 2020

Conversation

mmahadevan108
Copy link
Contributor

Summary of changes

Add Flash support for MXRT1050

Impact of changes

NONE

Migration actions required

NONE

Documentation

NONE

Pull request type 

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[X] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

mbedgt: checking for GCOV data...
mbedgt: mbed-host-test-runner: stopped and returned 'OK'
mbedgt: test on hardware with target id: 0227000041114e45004f3003b60f0045a6e1000097969900
mbedgt: test suite 'mbed-os-tests-mbed_hal-flash' .................................................... OK in 15.39 sec
test case: 'Flash - clock and cache test' .................................................... OK in 0.10 sec
test case: 'Flash - erase sector' ............................................................ OK in 0.93 sec
test case: 'Flash - init' .................................................................... OK in 0.08 sec
test case: 'Flash - mapping alignment' ....................................................... OK in 0.07 sec
test case: 'Flash - program page' ............................................................ OK in 0.92 sec
mbedgt: test case summary: 5 passes, 0 failures
mbedgt: all tests finished!
mbedgt: shuffle seed: 0.4889306488
mbedgt: test suite report:

target platform_name test suite result elapsed_time (sec) copy_method
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-mbed_hal-flash OK 15.39 default
mbedgt: test suite results: 1 OK
mbedgt: test case report:
target platform_name test suite test case passed failed
------------------------ ---------------- ------------------------------ ------------------------------ -------- --------
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-mbed_hal-flash Flash - clock and cache test 1 0
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-mbed_hal-flash Flash - erase sector 1 0
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-mbed_hal-flash Flash - init 1 0
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-mbed_hal-flash Flash - mapping alignment 1 0
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-mbed_hal-flash Flash - program page 1 0
mbedgt: test case results: 5 OK

Reviewers

@maclobdell

@mmahadevan108 mmahadevan108 changed the title MXRT Flash support MXRT1050 Flash support Jan 27, 2020
@ciarmcom ciarmcom requested review from maclobdell and a team January 27, 2020 22:00
@ciarmcom
Copy link
Member

@mmahadevan108, thank you for your changes.
@maclobdell @ARMmbed/mbed-os-maintainers please review.

maclobdell
maclobdell reviewed Jan 30, 2020
View reviewed changes
Copy link
Contributor

@maclobdell maclobdell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. @ARMmbed/mbed-os-maintainers please review and run CI. thanks!

@maclobdell maclobdell self-requested a review January 30, 2020 19:22
maclobdell
maclobdell previously approved these changes Jan 30, 2020
View reviewed changes
Copy link
Contributor

@maclobdell maclobdell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve

@mergify mergify bot added needs: CI and removed needs: review labels Jan 30, 2020
@mergify mergify bot dismissed maclobdell’s stale review January 30, 2020 21:51

Pull request has been modified.

@mmahadevan108
Copy link
Contributor Author

I made a small fix as I was seeing failures with the ARM toolchain. Now passing with all toolchains

@mergify mergify bot added the needs: work label Jan 31, 2020
@mergify
Copy link

mergify bot commented Jan 31, 2020

This PR cannot be merged due to conflicts. Please rebase to resolve them.

@mergify mergify bot removed the needs: CI label Jan 31, 2020
@mmahadevan108
MXRT1050: Update Flexspi driver to move functions to RAM
e46e482 
These functions are used to READ/WRITE to the Flexspi NOR

Signed-off-by: Mahesh Mahadevan <[email protected]>
@mmahadevan108
Copy link
Contributor Author

Rebased and updated PR

@mmahadevan108
Copy link
Contributor Author

I have added FLASHIAP support in this PR. Test results for FLASHIAP tests are given below:
mbedgt: checking for GCOV data...
mbedgt: mbed-host-test-runner: stopped and returned 'OK'
mbedgt: test on hardware with target id: 0227000041114e45004f3003b60f0045a6e1000097969900
mbedgt: test suite 'mbed-os-tests-mbed_drivers-flashiap' ............................................. OK in 22.28 sec
test case: 'FlashIAP - init' ................................................................. OK in 0.08 sec
test case: 'FlashIAP - program' .............................................................. OK in 1.79 sec
test case: 'FlashIAP - program across sectors' ............................................... OK in 1.79 sec
test case: 'FlashIAP - program errors' ....................................................... OK in 0.11 sec
test case: 'FlashIAP - timing' ............................................................... OK in 5.08 sec
mbedgt: test case summary: 5 passes, 0 failures
mbedgt: all tests finished!
mbedgt: shuffle seed: 0.0010688459
mbedgt: test suite report:

target platform_name test suite result elapsed_time (sec) copy_method
MIMXRT1050_EVK-ARMC6 MIMXRT1050_EVK mbed-os-tests-mbed_drivers-flashiap OK 22.28 default
mbedgt: test suite results: 1 OK
mbedgt: test case report:
target platform_name test suite test case passed failed
---------------------- ---------------- ------------------------------------- ----------------------------------- -------- --------
MIMXRT1050_EVK-ARMC6 MIMXRT1050_EVK mbed-os-tests-mbed_drivers-flashiap FlashIAP - init 1 0
MIMXRT1050_EVK-ARMC6 MIMXRT1050_EVK mbed-os-tests-mbed_drivers-flashiap FlashIAP - program 1 0
MIMXRT1050_EVK-ARMC6 MIMXRT1050_EVK mbed-os-tests-mbed_drivers-flashiap FlashIAP - program across sectors 1 0
MIMXRT1050_EVK-ARMC6 MIMXRT1050_EVK mbed-os-tests-mbed_drivers-flashiap FlashIAP - program errors 1 0
MIMXRT1050_EVK-ARMC6 MIMXRT1050_EVK mbed-os-tests-mbed_drivers-flashiap FlashIAP - timing 1 0
mbedgt: test case results: 5 OK

@mmahadevan108
MXRT1050: Add support for Flash driver
42a90cc 
Signed-off-by: Mahesh Mahadevan <[email protected]>
@mmahadevan108
MIMXRT1050: Reduce NOR size used by mbed-os
fa3a72e 
Reserve 4MB for mbed-os. The rest is used by storage driver

Signed-off-by: Mahesh Mahadevan <[email protected]>
@mmahadevan108
MIMXRT1050: Enable FlashIAP support
b5eb7bc 
Signed-off-by: Mahesh Mahadevan <[email protected]>
0xc0170
0xc0170 approved these changes Feb 4, 2020
View reviewed changes
targets/targets.json
@@ -2441,7 +2441,7 @@
"TRNG",
"FLASH",
"WATCHDOG"
],
],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got confused initially, as there was another PR as well touching these spaces. I left the comment here.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 4, 2020

CI started

@mergify mergify bot added needs: CI and removed needs: work labels Feb 4, 2020
@mergify mergify bot removed the needs: work label Feb 4, 2020
@mbed-ci
Copy link

mbed-ci commented Feb 4, 2020

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added the release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0 label Feb 4, 2020
@0xc0170 0xc0170 merged commit b33573e into ARMmbed:master Feb 4, 2020
@mergify mergify bot removed the ready for merge label Feb 4, 2020
@mmahadevan108 mmahadevan108 deleted the MXRT_FlashSupport branch February 10, 2020 21:26
@adbridge
Copy link
Contributor

Requested by Tuomo for consideration for LTS branch.

@artokin artokin mentioned this pull request Mar 3, 2020
Merged
@adbridge
Copy link
Contributor

adbridge commented Apr 8, 2020

This went to a feature branch so assuming this will not go across to 5.15 proper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@maclobdell maclobdell maclobdell left review comments

Assignees
No one assigned
Labels
release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mmahadevan108 @ciarmcom @0xc0170 @mbed-ci @adbridge @maclobdell