Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EFM32: Enable RESET_REASON and WATCHDOG for EFM32GG11_STK3701 #11844

Merged
merged 1 commit into from
Nov 15, 2019

Conversation

amq
Copy link
Contributor

@amq amq commented Nov 11, 2019

Description (required)

All EFM32 targets list RESET_REASON and WATCHDOG in device_has, apart of EFM32GG11_STK3701. There seems to be no reason for this, it was probably just missed by mistake. I have validated both features on a physical device and confirmed that they work.


Pull request type (required)

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results (required)

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR
Migration actions required (required)

None.

@ciarmcom ciarmcom requested a review from a team November 11, 2019 22:00
@ciarmcom
Copy link
Member

@amq, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 requested a review from a team November 12, 2019 10:15
@0xc0170
Copy link
Contributor

0xc0170 commented Nov 12, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Nov 12, 2019

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_unittests

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 13, 2019

CI restarted

@mbed-ci
Copy link

mbed-ci commented Nov 13, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 14, 2019

Test failed because of #11862, we will investigate

@adbridge
Copy link
Contributor

CI restarted

@mbed-ci
Copy link

mbed-ci commented Nov 15, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 3
Build artifacts

@0xc0170 0xc0170 removed the needs: CI label Nov 15, 2019
@0xc0170 0xc0170 merged commit 60a470a into ARMmbed:master Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants