Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXP: Enable MBED_TICKLESS on various NXP platforms #10796

Merged
merged 8 commits into from
Aug 22, 2019

Conversation

mmahadevan108
Copy link
Contributor

Description

Enable for K22F, K64F, K66F, K82F, KL82Z, KW24D, KW41Z, MIMXRT1050, HEXIWEAR

Pull request type

[ ] Fix
[ ] Refactor
[X] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@mmahadevan108
Copy link
Contributor Author

cc @maclobdell @0xc0170

@ciarmcom ciarmcom requested a review from a team June 7, 2019 19:00
@ciarmcom
Copy link
Member

ciarmcom commented Jun 7, 2019

@mmahadevan108, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@mmahadevan108
Copy link
Contributor Author

Test results below:
Sleep_Test_Results.txt

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 9, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jun 9, 2019

Test run: FAILED

Summary: 2 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_dynamic-memory-usage
  • jenkins-ci/mbed-os-ci_greentea-test

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 11, 2019

Please review test failures. I see in the logs few platforms that are affected here - related.

@mmahadevan108
Copy link
Contributor Author

Please review test failures. I see in the logs few platforms that are affected here - related.

How do I view the test failures

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 2, 2019

There's url above: https://mbed-os-ci.s3-website-eu-west-1.amazonaws.com/?prefix=jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-10796/artifacts/10796/

Go to greeen-tea tests and should have FAIL folder, download logs.

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 3, 2019

Note, the rebase needed for latest targets.json file

@mmahadevan108
Copy link
Contributor Author

Thanks @0xc0170 . I don't see the greentea tests in the link you sent.

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 10, 2019

Thanks @0xc0170 . I don't see the greentea tests in the link you sent.

Correct, looks like CI did not report back. We will restart testing once this is rebased.

@mmahadevan108
Copy link
Contributor Author

Thank you @0xc0170 . I have rebased this PR

@mmahadevan108
Copy link
Contributor Author

@0xc0170 . Please help with the test results

@bulislaw
Copy link
Member

@ARMmbed/mbed-os-maintainers can you restart the CI please, there's nothing useful in what CI reported.

@evedon
Copy link
Contributor

evedon commented Jul 17, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jul 17, 2019

Test run: FAILED

Summary: 2 of 11 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_dynamic-memory-usage
  • jenkins-ci/mbed-os-ci_greentea-test

@mbed-ci
Copy link

mbed-ci commented Aug 1, 2019

Test run: FAILED

Summary: 2 of 11 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_dynamic-memory-usage
  • jenkins-ci/mbed-os-ci_greentea-test

Enable for K22F, K64F, K66F, K82F, KL82Z, KW24D, KW41Z, MIMXRT1050, HEXIWEAR

Signed-off-by: Mahesh Mahadevan <[email protected]>
@mmahadevan108
Copy link
Contributor Author

Can you run the tests again. I believe all test failures should be fixed

1. Use the updated API's provided by the SMC driver
2. Wait till debug UART has finished transmitting data

Signed-off-by: Mahesh Mahadevan <[email protected]>
Update includes allocating RAM region for code to enter
stop modes and execute this code in RAM, thus the flash
is idle and no prefetch is performed while entering stop
mode.

Signed-off-by: Mahesh Mahadevan <[email protected]>
Wait till the data is flushed out of TX buffer

Signed-off-by: Mahesh Mahadevan <[email protected]>
Do not allow entry to deep sleep mode when SPI transfer is active

Signed-off-by: Mahesh Mahadevan <[email protected]>
Do not allow entry to deep sleep mode when UART transfer is active

Signed-off-by: Mahesh Mahadevan <[email protected]>
@mmahadevan108
Copy link
Contributor Author

Anything else needed for this?

@mmahadevan108
Copy link
Contributor Author

@0xc0170 Is there anything else needed for this PR?

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 20, 2019

Going to CI soon, all fine here. Sorry for the delay

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 21, 2019

CI restarted

@mbed-ci
Copy link

mbed-ci commented Aug 21, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 5
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-test

@mmahadevan108
Copy link
Contributor Author

I looked at the test log and cannot tell why this failure occurred.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 21, 2019

I restarted the client test, could not find neither

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 21, 2019

cc @mbed-os-test - looks like internal client test fault?

@adbridge
Copy link
Contributor

restarted

@mbed-ci
Copy link

mbed-ci commented Aug 21, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 6
Build artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants