Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Blog Post Visualizing Severe Weather in Wisconsin #1413

Merged
merged 3 commits into from
Apr 7, 2023

Conversation

mgrover1
Copy link
Collaborator

@mgrover1 mgrover1 commented Apr 7, 2023

  • Tests added
  • Documentation reflects changes

@mgrover1 mgrover1 requested a review from zssherman as a code owner April 7, 2023 17:01
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@mgrover1 mgrover1 changed the title add blog post on severe weather in wisconsin Add blog post on severe weather in Wisconsin Apr 7, 2023
@mgrover1 mgrover1 changed the title Add blog post on severe weather in Wisconsin Add a Blog Post Visualizing Severe Weather in Wisconsin Apr 7, 2023
@zssherman
Copy link
Collaborator

@mgrover1 Grabbed lunch real quick, will review shortly!

@zssherman
Copy link
Collaborator

zssherman commented Apr 7, 2023

@mgrover1 two mispells:
usign Py-ART!
to:
using Py-ART

Insterstate Date
to:
Interstate Data

import pyart
import fsspec
from metpy.plots import USCOUNTIES
import matplotlib.pyplot as plt
import cartopy.crs as ccrs
import cartopy.feature as cfeature
import cartopy.io.shapereader as shpreader
from cartopy.feature import ShapelyFeature
import pandas as pd
from datetime import datetime, timedelta
import warnings
import numpy as np

to PEP8:

from datetime import datetime, timedelta
import warnings

import cartopy.crs as ccrs
import cartopy.feature as cfeature
import cartopy.io.shapereader as shpreader
from cartopy.feature import ShapelyFeature
import fsspec
import matplotlib.pyplot as plt
from metpy.plots import USCOUNTIES
import numpy as np
import pandas as pd
import pyart

@mgrover1
Copy link
Collaborator Author

mgrover1 commented Apr 7, 2023

@zssherman I made those changes!

@zssherman
Copy link
Collaborator

zssherman commented Apr 7, 2023

Still seeing the using in 'using Py-ART mispelled as 'usign Py-ART' Exclamation point was fine to me haha

@mgrover1
Copy link
Collaborator Author

mgrover1 commented Apr 7, 2023

@zssherman fixed!

@zssherman
Copy link
Collaborator

Sweet! Merge away once the tests pass

@mgrover1 mgrover1 merged commit 67ee1a0 into ARM-DOE:main Apr 7, 2023
@mgrover1 mgrover1 deleted the add-new-severe-blog-post branch April 7, 2023 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants