Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADD: Adding code to convert data to AmeriFlux variable naming convent… #830

Merged
merged 1 commit into from
May 14, 2024
Merged

ADD: Adding code to convert data to AmeriFlux variable naming convent… #830

merged 1 commit into from
May 14, 2024

Conversation

AdamTheisen
Copy link
Collaborator

@AdamTheisen AdamTheisen commented May 7, 2024 •
edited
Loading

…ions.

  • Tests added
  • Documentation reflects changes
  • PEP8 Standards or use of linter
  • Xarray Dataset or DataArray variable naming follows 'ds' or 'da' naming

mgrover1
mgrover1 approved these changes May 7, 2024
View reviewed changes
Copy link
Collaborator

@mgrover1 mgrover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @AdamTheisen

zssherman
zssherman approved these changes May 7, 2024
View reviewed changes
Copy link
Collaborator

@zssherman zssherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well!

@zssherman
Copy link
Collaborator

zssherman commented May 8, 2024 •
edited
Loading

@AdamTheisen We good to merge this in? I'll probably do a release to get all these changes in.

@AdamTheisen
Copy link
Collaborator Author

@zssherman sorry, yes please go ahead!

@zssherman zssherman merged commit 4275696 into ARM-DOE:main May 14, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgrover1 mgrover1 mgrover1 approved these changes

@zssherman zssherman zssherman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AdamTheisen @zssherman @mgrover1