FIX: Many warning fixes for ACT. #822
Conversation
These fixes include datetime utc changes, missing images, xarray.dims to sizes changes and more.
|
For more on timezone fun, see here: |
There was a problem hiding this comment.
@zssherman are those barb baseline plots what we're producing now? Seems like there's not a lot there... No actual barbs. Thoughts?
|
@AdamTheisen Originally the plots u_v 3, 4 and5 were not producing plots and had a warning of future errors because of it, so I added the plot comparison plot. In terms of the small amounts of data in them, compared to u_v_1 I'm seeing the use of a real dataset, were the rest use a small fake ds, which could be the reason for that? Also the bins are set low it looks like. So i'm not 100% if because they are test ds that there is barely any data because its np.linspace fake data? But that was my assumption when I saw the plots. |
There was a problem hiding this comment.
@zssherman interesting. It looks like we just did it as a quick and easy way to test the plots which is fine. I may update these in the future to have something more than just 1 point though. Otherwise, I think this is good to go!
|
@AdamTheisen Sounds good! |
These fixes include datetime utc changes, missing images, xarray.dims to sizes changes and more.
Note I did a PR for icartt as well to fix there warnings, which will then suppress ours and will be doing one for PySP2 as well.