Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Update the cb_friendly to match cvd_friendly. #820

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

zssherman
Copy link
Collaborator

@zssherman zssherman commented Apr 10, 2024

This is so that the code matches the correct terminology.

  • Documentation reflects changes
  • PEP8 Standards or use of linter
  • Xarray Dataset or DataArray variable naming follows 'ds' or 'da' naming

This is so that the code matches the correct terminology.
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@mgrover1 mgrover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a linting error here - can you check that @zssherman ?

@zssherman
Copy link
Collaborator Author

@mgrover1 Done

@zssherman zssherman merged commit 3046a76 into ARM-DOE:main Apr 11, 2024
19 checks passed
@zssherman zssherman deleted the cb_rename branch April 11, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants