Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DatastreamParser to accecpt pathlib.PosixPath #809

Merged
merged 6 commits into from
Mar 11, 2024

Conversation

kenkehoe
Copy link
Contributor

@kenkehoe kenkehoe commented Mar 8, 2024

Updating DatastreamParserACT to accept pathlib.PosixPath as well as string paths. Fixing a few datetime64 calls to remove warnings during testing.

  • [X ] Tests added
  • [ X] Documentation reflects changes
  • [ X] PEP8 Standards or use of linter

Copy link
Collaborator

@zssherman zssherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Collaborator

@AdamTheisen AdamTheisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Will merge away.

@AdamTheisen AdamTheisen merged commit ef3ea10 into ARM-DOE:main Mar 11, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants