Updated to set data as Dask array back in Dataset if data is originally stored as Dask array #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y stored as Dask array.
|
Also, once this PR is merged can we make a release to provide access to some recent updates. @AdamTheisen |
|
Sounds good @kenkehoe requesting a review from @zssherman and then maybe after he can do a new release and work with @mgrover1 on getting familiar with our process |
zssherman
approved these changes
Apr 23, 2022
|
Sounds good @AdamTheisen ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this method was not storing the data back in the Dataset in the same format as was retrieved. This will check if data is set as Dask array and set data to same data type. Also, added some more tests.