-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Pinning numpy as binarys between releases are having issues etc. #439
Conversation
7ccd0ec
to
b1c163c
Compare
@AdamTheisen @mgrover1 So using the oldest supported numpy in the environment fixed the issue, however wondering if this is the route we want to go? Pinning numpy to the most recent version also solves this issue up into windows python 10 build. |
More on it here: |
@zssherman what was the issue with the Windows 10 build? |
@mgrover1 Similar to the msv_compiler missing module error that users have reported in Py-ART in the past |
|
Ahhh okay thanks @zssherman - I like the idea of pinning the oldest version of numpy, with the caveat that we look into why we can't use the newer versions... |
@mgrover1 going to try one more thing. real quick |
@zssherman looks like it's still failing with Windows Python 3.10 |
c37d98e
to
7084307
Compare
@mgrover1 Yeah I was trying to define the numpy build in pyproject, but didn't work sadly. |
@zssherman haven't had much time to look but will try tonight or later this week. With only one test failing, i want to see what can be done there before making a more significant change like this. Thoughts? |
@zssherman @mgrover1 Okay, I think I have a handle on this one and agree, let's pin this for now but as Max notes, look into the issue more. If you two agree, we can merge this in, just let me know. |
Yeah @AdamTheisen I think we should merge - some of the setuptools work that @zssherman has been pushing forward on should help solve some of these issues... |
Closes #438