-
-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fails to deref https schemas, strips https off URL, ignores 301 redirect to https #46
Comments
I noticed that this behavior does not occur when I serve my app with https. |
This error is caused by the URL resolution logic in the library. It currently defaults to the protocol of the host page, rather than the protocol of the schema URL. |
+1 |
I ended up writing my own resolver. Thanks for the awesome, easy to extend library :) |
Hi, this is a real problem and you can run into CORS problems too, see #58. But I didn't find out, where the protocol is lost... /EDIT: See Fix #59 |
Hi, the protocol wasn't present in the HTTP/HTTPS Get request. Fixes APIDevTools#58 and maybe partial APIDevTools#46.
This issue was fixed by PR #59 and released in version 4.0.4 |
This issue is only partial fixed. It won't follow the redirect for me. That still needs to be corrected! |
Oh... I didn't even notice the redirect part of the issue. I thought it was just about the protocol bug. Let's separate this into two different issues. If the protocol bug is fixed, but the redirect bug is not, then can you create a new issue for just the redirect bug? That'll make things easier to track. |
url ==
//json.readingpl.us/schemas/alertType.json
url SHOULD equal
https://json.readingpl.us/schemas/alertType.json
When redirected to HTTPS resource, it instead requests the HTTP resource again
The text was updated successfully, but these errors were encountered: