Do not download cargo in CI #2173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- switch deprecated actions-rs/toolchain, cf actions-rs/toolchain#216 - do not download cargo: it does not always work (e.g. macOS has several architectures but there is only one download), it is complex code, and we have a proper way to install it through CMake cf https://github.com/AOMediaCodec/libavif/blob/c21943e1e07ced29a22d1a59b0c4748e00b84c67/cmake/Modules/LocalRav1e.cmake#L49
y-guyon
approved these changes
May 23, 2024
y-guyon
reviewed
May 23, 2024
| toolchain: stable | ||
| override: true | ||
| - name: Set up rust | ||
| uses: dtolnay/rust-toolchain@stable |
There was a problem hiding this comment.
uses: dtolnay/rust-toolchain@d8352f6b1d2e870bc5716e7a6d9b65c4cc244a1aThere was a problem hiding this comment.
Maybe take the last commit from the stable branch so dtolnay/rust-toolchain@d388a48
There was a problem hiding this comment.
Usually people tag. stable is a branch. But yes, it is safer. Done
There was a problem hiding this comment.
It is not possible to stick to a commit. Reverting the rust dependency. What really matters in this PR is the cargo install.
y-guyon
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libavif/cmake/Modules/LocalRav1e.cmake
Line 49 in c21943e