Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpv shaders : terrible arifacts with temporal variants of nlmeans #10

Open
hooke007 opened this issue Jul 11, 2023 · 13 comments
Open

mpv shaders : terrible arifacts with temporal variants of nlmeans #10

hooke007 opened this issue Jul 11, 2023 · 13 comments

Comments

@hooke007
Copy link

hooke007 commented Jul 11, 2023

I know they are "Very experimental and buggy"
Open an issue to record its behav may be better.

I only tested the shaders in hq folder. d682103

Sometimes the artifacts were dots instead of blocks.

The one possible reason is that the lack of scene's changing's detection algorithm ?
It's obvious those wrong pixels come from the last frame.(Also some next fram's pixels come into the last one.)

@Trinity3e
Copy link

How about with the lq ones?

@hooke007
Copy link
Author

Similar blocks.

@AN3223
Copy link
Owner

AN3223 commented Jul 12, 2023

Can you see if 31d545f helps? It appears to resolve it on my system, but the issue was always intermittent for me so it's difficult to be sure.

The one possible reason is that the lack of scene's changing's detection algorithm ? It's obvious those wrong pixels come from the last frame.(Also some next fram's pixels come into the last one.)

This is handled implicitly BTW.

@hooke007
Copy link
Author

hooke007 commented Jul 12, 2023

It helps but not enough...hq

@AN3223
Copy link
Owner

AN3223 commented Jul 12, 2023

It helps but not enough...

What resolution is the source video?

@hooke007
Copy link
Author

@AN3223
Copy link
Owner

AN3223 commented Jul 12, 2023

Do you only see artifacts around motion now?

@hooke007
Copy link
Author

No, I could even see them on those static color-testing clip.

@AN3223
Copy link
Owner

AN3223 commented Jul 12, 2023

Is the clip 4K?

@hooke007
Copy link
Author

Yes but 1080p also showed many dots.

@AN3223
Copy link
Owner

AN3223 commented Jul 12, 2023

Ah, not sure then...

@hooke007
Copy link
Author

hooke007 commented Jul 12, 2023

It seem to be another vulkan bug (Nvidia). All variants work well with gpu-context=win (WGL)

edit: Confirmed gpu-context=winvk for AMD is safe.

@hooke007
Copy link
Author

The workaround for windows Nvidia users:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants