Skip to content
This repository has been archived by the owner on Jun 7, 2023. It is now read-only.

Add ability to ignore labels #155

Closed
HumairAK opened this issue Jul 16, 2021 · 5 comments
Closed

Add ability to ignore labels #155

HumairAK opened this issue Jul 16, 2021 · 5 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@HumairAK
Copy link
Collaborator

The way I understand it, PAD will need to be restarted whenever a label updates. This is an issue for when dealing with metrics that contain pod names as a label for example. If the pod has a generated suffix, a new one is generated upon each restart, thus requiring pad to be restarted, and being unable to leverage the old pod's historical data (iiuc).

It would be nice if I could pass a flag or file with a list of labels to ignore :)

@4n4nd
Copy link
Contributor

4n4nd commented Jul 16, 2021

This is a great suggestion.
I think we could add a new flag something like
FLT_IGNORE_LABEL_CHANGES="pod_name, pod_ip" and it would ignore the changes in those specific labels.

@sesheta
Copy link

sesheta commented Oct 16, 2021

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@sesheta sesheta added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 16, 2021
@sesheta
Copy link

sesheta commented Nov 15, 2021

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

@sesheta sesheta added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 15, 2021
@sesheta
Copy link

sesheta commented Dec 15, 2021

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

@sesheta
Copy link

sesheta commented Dec 15, 2021

@sesheta: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sesheta sesheta closed this as completed Dec 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

3 participants