Skip to content
This repository has been archived by the owner on Jun 7, 2023. It is now read-only.

Support Skipping Bad Metrics Queries Rather Crashing PAD #143

Closed
Carmezim opened this issue May 3, 2021 · 5 comments
Closed

Support Skipping Bad Metrics Queries Rather Crashing PAD #143

Carmezim opened this issue May 3, 2021 · 5 comments
Assignees
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@Carmezim
Copy link

Carmezim commented May 3, 2021

Thank you for the great work and very useful model.

I was wondering it could be interesting to support handling some bad or faulty queries that cause the app to crash.

E.g.:

HTTP Status Code 400 (b'{"status":"error","errorType":"bad_data","error":"invalid parameter \\"query\\": 1:218: parse error: unexpected identifier \\"s\\" in label matching, expected \\",\\" or \\"}\\""}'

or

Max retries exceeded with url

etc.

The whole app crashes and restarts training from the beginning.

@Carmezim
Copy link
Author

Carmezim commented May 3, 2021

This should be possible to handle through PrometheusConnect retry param (urllib3.util.Retry)

@Carmezim Carmezim closed this as completed May 3, 2021
@Carmezim Carmezim reopened this May 4, 2021
@4n4nd 4n4nd self-assigned this May 10, 2021
@sesheta
Copy link

sesheta commented Oct 14, 2021

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@sesheta sesheta added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 14, 2021
@sesheta
Copy link

sesheta commented Nov 13, 2021

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

@sesheta sesheta added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 13, 2021
@sesheta
Copy link

sesheta commented Dec 14, 2021

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

@sesheta sesheta closed this as completed Dec 14, 2021
@sesheta
Copy link

sesheta commented Dec 14, 2021

@sesheta: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

3 participants