Update coding style. #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AFathi
reviewed
Jul 29, 2018
ARVideoKit/Rendering/RenderAR.swift
Outdated
| init(_ ARview:Any?, renderer:SCNRenderer, contentMode:ARFrameMode) { | ||
| struct RenderAR { | ||
| private var view: Any? | ||
| private var renderEngine: SCNRenderer! |
There was a problem hiding this comment.
this will cause memory leaks. you may keep the private tag but make this variable global (outside the struct)
AFathi
reviewed
Jul 29, 2018
ARVideoKit/Rendering/RenderAR.swift
Outdated
| internal var ARcontentMode:ARFrameMode! | ||
| init(_ ARview:Any?, renderer:SCNRenderer, contentMode:ARFrameMode) { | ||
| struct RenderAR { | ||
| private var view: Any? |
There was a problem hiding this comment.
this will cause memory leaks. you may keep the private tag but make this variable global (outside the struct)
AFathi
reviewed
Jul 29, 2018
| @@ -8,33 +8,37 @@ | |||
|
|
|||
| import Foundation | |||
| import ARKit | |||
| fileprivate var view:Any? | |||
| fileprivate var renderEngine:SCNRenderer! | |||
|
|
|||
There was a problem hiding this comment.
remove the following from struct RenderAR and put it here:
private var view: Any?
private var renderEngine: SCNRenderer!
There was a problem hiding this comment.
updated 62f90d0, Sorry, seems I forgot to push my commit here.
There was a problem hiding this comment.
Ah... the code is already committed.
There was a problem hiding this comment.
@pingchen114, will review it and get back to you soon
|
Thanks for the quick review, I am fixing it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request contains the following coding style updates.
internalkeyword since it is already the default attribute.fileprivatewithprivateregarding to Swift 4.;symbolReference
https://google.github.io/swift/
https://github.com/raywenderlich/swift-style-guide