Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort of fix core affinity on mac arm64 #873

Merged
merged 6 commits into from
Nov 5, 2022

Conversation

devnexen
Copy link
Contributor

we can t pin to a coreid however we can at least choose the performance cores for our thread.

we can t pin to a coreid however we can at least choose the performance
cores for our thread.
@domenukk
Copy link
Member

domenukk commented Oct 29, 2022

If there are 8 cores, 4 perf and 4 non-perf, wouldn't we want to use all 8?

@domenukk
Copy link
Member

Maybe even pinning to the lower 4 cores > perf, pinning to the upper 4 cores > non-perf, or something like that?
Or a differently named function?

@devnexen
Copy link
Contributor Author

Maybe even pinning to the lower 4 cores > perf, pinning to the upper 4 cores > non-perf, or something like that? Or a differently named function?

non-perf are more fit for background tasks.

@domenukk
Copy link
Member

Yes I understand, but still, wouldn't 8 fuzzer processes on all 8 cores be faster than 4 on 4 perf cores? (thermal issues ignored)

@tokatoka
Copy link
Member

tokatoka commented Nov 5, 2022

it has a clippy error
please fix this

error: unused import: `KERN_NOT_SUPPORTED`
   --> libafl/src/bolts/core_affinity.rs:538:60
    |
538 |         thread_policy_flavor_t, thread_policy_t, thread_t, KERN_NOT_SUPPORTED, KERN_SUCCESS,
    |                                                            ^^^^^^^^^^^^^^^^^^
    |
note: the lint level is defined here
   --> libafl/src/lib.rs:65:9
    |
65  |         unused,
    |         ^^^^^^
    = note: `#[deny(unused_imports)]` implied by `#[deny(unused)]`

error: could not compile `libafl` due to previous error

thanks

@tokatoka tokatoka merged commit b9bd0dd into AFLplusplus:main Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants