Closure builder for inner managers of centralized. #2279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tokatoka
reviewed
Jun 5, 2024
libafl/src/events/launcher.rs
Outdated
| MIMF: FnOnce(&Self, CoreId) -> Result<(Option<S>, MIM), Error>, | ||
| { | ||
| let mut main_inner_mgr_builder = Some(main_inner_mgr_builder); | ||
| let mut client_inner_mgr_builder = Some(client_inner_mgr_builder); |
There was a problem hiding this comment.
secondary_inner_mgr_builder?
i think main evaluator is client too,
There was a problem hiding this comment.
yes ur right its better
There was a problem hiding this comment.
i'll change other places where its not consistent with this notation
tokatoka
reviewed
Jun 5, 2024
libafl/src/events/launcher.rs
Outdated
| } | ||
|
|
||
| #[cfg(all(unix, feature = "std", feature = "fork"))] | ||
| impl<CF, MF, MT, S, SP> Debug for CentralizedLauncher<'_, CF, MF, MT, S, SP> { | ||
| impl<CF, CIM, MF, MIM, MT, S, SP> Debug for CentralizedLauncher<'_, CF, CIM, MF, MIM, MT, S, SP> { |
There was a problem hiding this comment.
imo cim should always be the same as mim. what do you think.
so we can delete mim and just keep cim
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the closures are different for the main node and the secondary nodes for finer-grained configuration.