Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce feedbacks hit tracking for testcases #2248

Merged
merged 22 commits into from
May 28, 2024
Merged

Introduce feedbacks hit tracking for testcases #2248

merged 22 commits into from
May 28, 2024

Conversation

R9295
Copy link
Contributor

@R9295 R9295 commented May 24, 2024 •
edited
Loading

Work in progress.

I decided to use Name instead of Handle since Feedback is a trait and I'm not sure how that would work for Testcase since Handle expects a type. Maybe we can make a wrapper type? TrackedFeedback?

Once the general approach is decided, the implementation will be done for Objective as well

R9295
R9295 commented May 24, 2024
View reviewed changes
libafl_nyx/src/executor.rs Outdated Show resolved Hide resolved
libafl_qemu/src/emu/mod.rs Outdated Show resolved Hide resolved
@domenukk
Copy link
Member

This is super cool!

@R9295 R9295 requested a review from domenukk May 24, 2024 14:44
@domenukk domenukk marked this pull request as draft May 24, 2024 16:57
@domenukk domenukk marked this pull request as draft May 24, 2024 16:57
@domenukk domenukk marked this pull request as draft May 24, 2024 16:57
@R9295 R9295 marked this pull request as ready for review May 25, 2024 12:23
@R9295 R9295 changed the title [WIP] introduce feedbacks hit tracking for testcases Introduce feedbacks hit tracking for testcases May 25, 2024
domenukk
domenukk reviewed May 27, 2024
View reviewed changes
libafl_bolts/src/lib.rs Outdated Show resolved Hide resolved
domenukk
domenukk reviewed May 27, 2024
View reviewed changes
libafl/src/stages/tmin.rs Outdated Show resolved Hide resolved
@domenukk
Copy link
Member

LGTM, sadly CI is not working, so I don't know if we should merge anything right now ..

@domenukk domenukk merged commit bce0f08 into AFLplusplus:main May 28, 2024
47 of 102 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nezza nezza nezza left review comments

@domenukk domenukk domenukk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@R9295 @domenukk @nezza