-
-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce feedbacks hit tracking for testcases #2248
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
R9295
commented
May 24, 2024
domenukk
reviewed
May 24, 2024
domenukk
reviewed
May 24, 2024
domenukk
reviewed
May 24, 2024
domenukk
reviewed
May 24, 2024
domenukk
reviewed
May 24, 2024
domenukk
reviewed
May 24, 2024
domenukk
reviewed
May 24, 2024
domenukk
reviewed
May 24, 2024
domenukk
reviewed
May 24, 2024
domenukk
reviewed
May 24, 2024
domenukk
reviewed
May 24, 2024
domenukk
reviewed
May 24, 2024
This is super cool! |
rename get_hit_feedbacks to append_hit_feedbacks update documentation
domenukk
reviewed
May 24, 2024
…eedback, NautilusFeedback
domenukk
reviewed
May 25, 2024
domenukk
reviewed
May 27, 2024
domenukk
reviewed
May 27, 2024
domenukk
reviewed
May 27, 2024
LGTM, sadly CI is not working, so I don't know if we should merge anything right now .. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress.
I decided to use Name instead of Handle since Feedback is a trait and I'm not sure how that would work for Testcase since Handle expects a type. Maybe we can make a wrapper type?
TrackedFeedback
?Once the general approach is decided, the implementation will be done for
Objective
as well