-
-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add AFL stage names for calibration, colorization, power and sync stages #2209
Conversation
change set_name to with_name for PowerMutationalStage remove irrelevant fn transforming
libafl/src/stages/sync.rs
Outdated
load_callback, | ||
phantom: PhantomData, | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
usually we have a space between functions
Thinking about this - we could also AFL-ify these names by default, they don't matter too much, right? |
i think it's good |
yes i think there's no really any meaning to give different names to the stage. so it can be default |
libafl/src/stages/calibrate.rs
Outdated
@@ -60,11 +60,16 @@ impl UnstableEntriesMetadata { | |||
} | |||
} | |||
|
|||
/// Default name for `CalibrationStage` | |||
pub const CALIBRATION_STAGE_NAME: &str = "CalibrationStage"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, this guy can go, we'll use the AFL variant as default. Keep the info that this resembles afl's name around in the docstring (and maybe add the info about the name to new
).
In any case, I think we may want a constructor for custom names down the road else we can't have multiple instances of the same stage (right?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@domenukk AFL variant as default just for calibration? or for sync & colorization too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you don't need this name in my opinion. just keep
pub const CALIBRATION_STAGE_NAME: &str = "calibration"
and then it's fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In any case, I think we may want a constructor for custom names down the road else we can't have multiple instances of the same stage (right?)
we can have multiple same stages. but more imporantly we don't use name anymore because we have the handle. so it doesn't hatter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@R9295 you make afl name default for all
good |
…ges (AFLplusplus#2209) * add AFL stage names for calibration, colorization, power and sync stages * clippy * add missing name field in sync stage * use consts instead of hardcoding in functions. change set_name to with_name for PowerMutationalStage remove irrelevant fn transforming * make AFL++ name default for all stages
Implements and closes #2179