Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(workflows): update GitHub Actions for Helm chart automation #94

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

TartanLeGrand
Copy link
Contributor

@TartanLeGrand TartanLeGrand commented Jun 9, 2024

Overview πŸ“

This update revises the GitHub Action workflow for releasing Helm charts, focusing on improving the process for pushing tags and managing releases to an OCI registry.

Details of Changes πŸ› οΈ

  • Trigger Adjustment: The workflow now triggers on any new tag push, rather than on branch pushes, aligning with best practices for release management.
  • Helm and Docker Integration: Enhanced to use the latest actions for Helm setup and Docker login, ensuring compatibility and security.
  • Release Management: Utilizes helm/[email protected] for packaging and docker/login-action@v3 for pushing charts to a specified OCI registry.
  • Git Configuration: Standardizes Git setup for actions to ensure proper authorship is recorded.
  • Deployment Process: Added detailed steps for logging into 8gears.container-registry.com and pushing Helm charts directly to this OCI registry.

Justification πŸ“Š

These changes are designed to streamline the release process by:

  • Ensuring that releases are tied to version tags, which helps in tracking and rollback.
  • Automating the distribution of charts to our OCI registry, which simplifies deployment and access management.
  • Improving security and maintainability of the deployment scripts.

Discussion Point πŸ€”

In response to Issue #27 regarding the automation of Helm chart deployments to an OCI registry: while this setup enhances our deployment capabilities, I'd like to propose a discussion about potentially deploying our charts directly on GitHub Pages as well. This could simplify access and distribution. What are the considerations against using GitHub Pages for this purpose?

Action Requested πŸ“¬

Please review the proposed changes for their impact on our release process. Feedback, suggestions, or approval for merge would be greatly appreciated to enhance our Helm chart management strategy.

Summary by CodeRabbit

  • Chores
    • Added GitHub Actions workflows for commit checks, linting, and chart releases.
    • Updated .gitignore to exclude .idea and .vscode directories.

@TartanLeGrand TartanLeGrand requested a review from a team as a code owner June 9, 2024 22:58
@Vad1mo
Copy link
Member

Vad1mo commented Jun 11, 2024

@coderabbitai review

Copy link

coderabbitai bot commented Jun 11, 2024

Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copy link

coderabbitai bot commented Jun 11, 2024

Walkthrough

The recent updates introduce several GitHub Actions workflows to enhance the CI/CD pipeline. These workflows include checks for conventional commit messages, linting and testing Helm charts, releasing charts on tag pushes, and automating releases. Additionally, .idea and .vscode directories are now ignored in the .gitignore file. These changes aim to streamline development processes and ensure code quality.

Changes

Files/Paths Change Summary
.github/workflows/conventional-commits-check.yaml Added a workflow to check for conventional commit messages on pull requests to the master branch.
.github/workflows/lint.yaml Introduced a workflow to lint and test Helm charts on pull requests.
.github/workflows/push.yaml Created a workflow to release Helm charts on tag pushes, including tasks like code checkout, Git configuration, and chart pushing.
.github/workflows/release.yaml Added a workflow to automate releases using the google-github-actions/release-please-action@v4.
.gitignore Updated to ignore .idea and .vscode directories.

Poem

In the code’s domain, where actions flow,
New workflows sprout, making progress grow.
Commits now checked, charts linted with care,
Releasing with ease, no more despair.
Ignored are the files from IDE's nest,
Our CI/CD pipeline, truly the best!


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 5faf7c1 and 2dc11fc.

Files selected for processing (5)
  • .github/workflows/conventional-commits-check.yaml (1 hunks)
  • .github/workflows/lint.yaml (1 hunks)
  • .github/workflows/push.yaml (1 hunks)
  • .github/workflows/release.yaml (1 hunks)
  • .gitignore (1 hunks)
Files skipped from review due to trivial changes (5)
  • .github/workflows/conventional-commits-check.yaml
  • .github/workflows/lint.yaml
  • .github/workflows/push.yaml
  • .github/workflows/release.yaml
  • .gitignore

Copy link
Member

@Vad1mo Vad1mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wonderful.

  • I would like to see also some builds, lints and test for each PR. So we can verify basic things work before looking deeper into it. But I guess this also could be some GitHub marketplace bots.
  • Also, building a chart with a prerelease would be nice on each merge and commit on main

@Vad1mo Vad1mo merged commit d638a48 into 8gears:master Jun 11, 2024
@Vad1mo
Copy link
Member

Vad1mo commented Jun 11, 2024

I created some new issues related to that.

#97

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants