Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle null logger name for acceptable check #2145

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

cholmes-axoni
Copy link
Contributor

The acceptable check doesn't handle null logger names as the mkEntry does. This prevents it from failing for that null value.

This is an addition to a previous change. #1990

Let me know if this isn't the desired behavior and if records with null logger names should either always be accepted or never accepted.

[error]   NullPointerException
[error] 
[error]   StringOps.scala:836               scala.collection.StringOps$#split$extension
[error]   LogConfigServiceImpl.scala:21     izumi.logstage.api.routing.LogConfigServiceImpl#threshold
[error]   ConfigurableLogRouter.scala:38    izumi.logstage.api.routing.ConfigurableLogRouter#acceptable
[error]   LogstageJulLogger.scala:22        izumi.logstage.adapter.jul.LogstageJulLogger#publish
[error]   Logger.java:979                   java.util.logging.Logger#log

Copy link
Member

@neko-kai neko-kai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much! 🙏

@neko-kai neko-kai merged commit c6f03dd into 7mind:develop Jun 28, 2024
neko-kai added a commit that referenced this pull request Jun 28, 2024
* Handle null logger name for acceptable check

* Update logstage/logstage-core/.jvm/src/main/scala/izumi/logstage/adapter/jul/LogstageJulLogger.scala

---------

Co-authored-by: Kai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants