Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choose site from a list for ease #78

Merged
merged 5 commits into from
Jun 14, 2024
Merged

Choose site from a list for ease #78

merged 5 commits into from
Jun 14, 2024

Conversation

5ouma
Copy link
Owner

@5ouma 5ouma commented Jun 14, 2024

⚠️ Issue

close #8


✔︎ Checklists

  • This Pull Request introduces a new feature.
  • This Pull Request fixes a bug.

🔄 Type of the Change

  • 🎉 Feature
  • 🧰 Bug
  • 🛡️ Security
  • 📖 Documentation
  • 🧹 Refactoring
  • 🧪 Testing
  • 🔧 Maintenance
  • 🎽 CI
  • ⛓️ Dependencies
  • 🧠 Meta

✏️ Description

Users don't need to write a full URL for enumerated sites.


Users don't need to write a full URL for enumerated sites.
@prlabeler prlabeler bot added the 🎉 New Feature Introduce a new feature label Jun 14, 2024
It's not recommended to write xmlUrl directly.
@5ouma 5ouma linked an issue Jun 14, 2024 that may be closed by this pull request
3 tasks
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3ed4218) to head (5577b42).

Additional details and impacted files
@@            Coverage Diff            @@
##               dev       #78   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         3    +1     
  Lines           52        74   +22     
  Branches         4        12    +8     
=========================================
+ Hits            52        74   +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Check to transcode XML URL from an id.
Output the easy-to-understand message for fixing a TOML file.
Get site URL if `xmlUrl` is not set.
@5ouma 5ouma changed the title feat(site): Choose site from a list for ease Choose site from a list for ease Jun 14, 2024
@5ouma 5ouma merged commit 2f6a653 into dev Jun 14, 2024
6 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feat-site branch June 14, 2024 06:32
5ouma added a commit that referenced this pull request Jun 14, 2024
Users don't need to write a full URL for enumerated sites.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 New Feature Introduce a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Types to choose specific web site
1 participant