Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 [security] Update nokogiri: 1.8.2 β†’ 1.8.4 (patch) #22

Closed
wants to merge 1 commit into from

Conversation

depfu[bot]
Copy link

@depfu depfu bot commented Jul 4, 2018


🚨 Your version of nokogiri has known security vulnerabilities 🚨

Advisory: CVE-2018-8048
Disclosed: March 29, 2018
URL: https://github.com/sparklemotion/nokogiri/pull/1746

Revert libxml2 behavior in Nokogiri gem that could cause XSS

[MRI] Behavior in libxml2 has been reverted which caused
CVE-2018-8048 (loofah gem), CVE-2018-3740 (sanitize gem), and
CVE-2018-3741 (rails-html-sanitizer gem). The commit in question is
here:

GNOME/libxml2@960f0e2

and more information is available about this commit and its impact
here:

flavorjones/loofah#144

This release simply reverts the libxml2 commit in question to protect
users of Nokogiri's vendored libraries from similar vulnerabilities.

If you're offended by what happened here, I'd kindly ask that you
comment on the upstream bug report here:

https://bugzilla.gnome.org/show_bug.cgi?id=769760


🚨 We recommend to merge and deploy this update as soon as possible! 🚨

We've updated a dependency and all tests pass. \o/

name version specification old version new version
nokogiri 1.8.2 1.8.4

You should probably take a good look at this before merging this pull request, of course.

What changed?

✳️ nokogiri (1.8.2 β†’ 1.8.4) Β· Repo Β· Changelog

Commits

See the full diff on Github. The new version differs by more commits than we can show here.


Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

Depfu Status

@depfu depfu bot added the depfu label Jul 4, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at 85.43% when pulling 1d2d681 on depfu/update/nokogiri-1.8.4 into d454fde on master.

@depfu depfu bot changed the title Update nokogiri: 1.8.2 β†’ 1.8.4 (patch) 🚨 [security] Update nokogiri: 1.8.2 β†’ 1.8.4 (patch) Jul 5, 2018
@thisismydesign
Copy link
Member

The old app is no longer supported.

@thisismydesign thisismydesign deleted the depfu/update/nokogiri-1.8.4 branch September 5, 2019 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants