Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies, fix reconnection and implement darkmode #192

Closed
wants to merge 6 commits into from

Conversation

mfjordvald
Copy link

Apologies for a bit of a wide-ranging PR. I wanted to make some changes for myself and ended up doing a bit of maintenance to remove the deprecation warnings in the console.

The biggest maintenance items here are:

  • Updates Electron to v23
  • Updates React to v18
  • Updates Mui styling components to v5
  • Updates Material table to v6

In addition this PR fixes #191 and implements #142 #165

The #191 fix is done by explicitly calling the connect function since simply calling disconnect will not trigger auto-reconnect if the socket already had an abnormal disconnection.

The dark mode feature selects the light/dark Mui palette based on the system preference.

@mfjordvald mfjordvald closed this Mar 25, 2023
@mfjordvald mfjordvald reopened this Mar 25, 2023
@mfjordvald
Copy link
Author

Linting is freaking out since the used babel-eslint package is deprecated, the new @babel/eslint-parser package that replaces it functions correctly but calls out a bunch of the existing code that I didn't touch. I'm guessing that the currenting linting setup simply isn't using the majority of the linting packages it includes.

Happy to work on fixing up the linting but it is probably better done in a different PR as it will touch a lot of files and obscure the more impactful changes.

@thisismydesign
Copy link
Member

Thanks a lot for your effort @mfjordvald! I'll review it next week.

Copy link
Member

@thisismydesign thisismydesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mfjordvald Sorry for the delay. The code looks good! It would be worthwhile to add a switch for dark mode in the settings (on/off/system) if you feel up for it, but this is also fine.

Could you enable github actions on your fork so CI can run?

And could you create another PR to deal with lining? Either on top of this or based on master.

When I see the CI passing all steps I'm happy to merge and create a new release! Thanks again for your work.

@thisismydesign
Copy link
Member

@mfjordvald Please merge master, that should enable the CI to run on your PR.

@mfjordvald mfjordvald closed this Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Individual Item Reconnect does not work, but Reconnect All does
2 participants