Skip to content

Commit

Permalink
contra, fractal: Remove wrongly copypasted pin E6 manipulation code (q…
Browse files Browse the repository at this point in the history
…mk#14818)

Apparently the default keymaps for `contra` and `fractal` were derived
from some `planck` keymap which contained code to control the status LED
in the implementation of the `BACKLIT` custom keycode.  Unfortunately,
the code to control the LED manipulated the `E6` pin directly, and it
was copied without changes, but the `contra` and `fractal` boards use
the `E6` pin in the matrix, therefore pressing the key mapped to
`BACKLIT` resulted in phantom keypresses for all keys in the
corresponding column.
  • Loading branch information
sigprof committed Oct 14, 2021
1 parent 04cf161 commit f9f3a11
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
2 changes: 0 additions & 2 deletions keyboards/contra/keymaps/default/keymap.c
Original file line number Diff line number Diff line change
Expand Up @@ -222,10 +222,8 @@ bool process_record_user(uint16_t keycode, keyrecord_t *record) {
#ifdef BACKLIGHT_ENABLE
backlight_step();
#endif
PORTE &= ~(1<<6);
} else {
unregister_code(KC_RSFT);
PORTE |= (1<<6);
}
return false;
break;
Expand Down
2 changes: 0 additions & 2 deletions keyboards/fractal/keymaps/default/keymap.c
Original file line number Diff line number Diff line change
Expand Up @@ -213,10 +213,8 @@ bool process_record_user(uint16_t keycode, keyrecord_t *record) {
#ifdef BACKLIGHT_ENABLE
backlight_step();
#endif
PORTE &= ~(1<<6);
} else {
unregister_code(KC_RSFT);
PORTE |= (1<<6);
}
return false;
break;
Expand Down

0 comments on commit f9f3a11

Please sign in to comment.