Skip to content

Commit

Permalink
Fix backlight for F401/F411 blackpill onekey examples (qmk#10320)
Browse files Browse the repository at this point in the history
Fix configs to make the `handwired/onekey/blackpill_f401:backlight` and
`handwired/onekey/blackpill_f411:backlight` examples actually compile
and work:

 - Use `PWMD5` instead of `PWMD2` for backlight, which matches the
   default value of `BACKLIGHT_PAL_MODE` (AF02 for pin A0 is `TIM5_CH1`)
   and does not conflict with the default value of `STM32_ST_USE_TIMER`.

 - Enable `HAL_USE_PWM` in halconf.h and `STM32_PWM_USE_TIM5` in
   mcuconf.h, so that `PWMD5` could be used.
  • Loading branch information
sigprof committed Sep 22, 2020
1 parent ea0cf42 commit 7ddae97
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 2 deletions.
2 changes: 1 addition & 1 deletion keyboards/handwired/onekey/blackpill_f401/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
#define UNUSED_PINS

#define BACKLIGHT_PIN A0
#define BACKLIGHT_PWM_DRIVER PWMD2
#define BACKLIGHT_PWM_DRIVER PWMD5
#define BACKLIGHT_PWM_CHANNEL 1

#define RGB_DI_PIN A1
Expand Down
1 change: 1 addition & 0 deletions keyboards/handwired/onekey/blackpill_f401/halconf.h
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,6 @@
#pragma once

#define HAL_USE_I2C TRUE
#define HAL_USE_PWM TRUE

#include_next "halconf.h"
3 changes: 3 additions & 0 deletions keyboards/handwired/onekey/blackpill_f401/mcuconf.h
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,6 @@

#undef STM32_I2C_USE_I2C1
#define STM32_I2C_USE_I2C1 TRUE

#undef STM32_PWM_USE_TIM5
#define STM32_PWM_USE_TIM5 TRUE
2 changes: 1 addition & 1 deletion keyboards/handwired/onekey/blackpill_f411/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
#define UNUSED_PINS

#define BACKLIGHT_PIN A0
#define BACKLIGHT_PWM_DRIVER PWMD2
#define BACKLIGHT_PWM_DRIVER PWMD5
#define BACKLIGHT_PWM_CHANNEL 1

#define RGB_DI_PIN A1
Expand Down
1 change: 1 addition & 0 deletions keyboards/handwired/onekey/blackpill_f411/halconf.h
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,6 @@
#pragma once

#define HAL_USE_I2C TRUE
#define HAL_USE_PWM TRUE

#include_next "halconf.h"
3 changes: 3 additions & 0 deletions keyboards/handwired/onekey/blackpill_f411/mcuconf.h
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,6 @@

#undef STM32_I2C_USE_I2C1
#define STM32_I2C_USE_I2C1 TRUE

#undef STM32_PWM_USE_TIM5
#define STM32_PWM_USE_TIM5 TRUE

0 comments on commit 7ddae97

Please sign in to comment.