Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/jmcc allow custom session to be provided #274

Conversation

jmcconnell26
Copy link
Contributor

We ran into this issue when attempting to use mTLS to connect to a prometheus instance, but there are several examples where it may be useful to allow for complex Session configurations.

If there are any changes you'd like me to make, please let me know!

Thanks,
Josh

Copy link
Owner

@4n4nd 4n4nd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@4n4nd
Copy link
Owner

4n4nd commented Feb 21, 2024

Thanks for the PR!

@4n4nd 4n4nd merged commit f3f03ed into 4n4nd:master Feb 21, 2024
@4n4nd 4n4nd mentioned this pull request Feb 21, 2024
@jmcconnell26 jmcconnell26 deleted the feature/jmcc-allow-custom-session-to-be-provided branch July 15, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants