Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Proxy Feature #261 #262

Merged
merged 2 commits into from
May 15, 2023
Merged

Added Proxy Feature #261 #262

merged 2 commits into from
May 15, 2023

Conversation

mayankkholia
Copy link

@mayankkholia mayankkholia commented Apr 28, 2023

Adding option to use proxy for connecting to prometheus.

@4n4nd
Copy link
Owner

4n4nd commented Apr 29, 2023

@mayankkholia could you add a description to this PR about the changes you are making?
Also could you please add the proxy usage in function docs?

@mayankkholia
Copy link
Author

@mayankkholia could you add a description to this PR about the changes you are making? Also could you please add the proxy usage in function docs?

done, thanks for helping :)

Copy link
Owner

@4n4nd 4n4nd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thanks!

@4n4nd 4n4nd merged commit 0e73e83 into 4n4nd:master May 15, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants