prometheus_connect: Store "variance" operation result with the correc… #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t key Signed-off-by: shimon-armis <[email protected]>
|
Hey @4n4nd , Can u plz check this out? |
|
@4n4nd Can u please review this PR and refer to the questions above? |
for first time contributors, we need to approve the tests that need to be run
Only project maintainers/collaborators can merge a PR |
Thanks @4n4nd ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t key
This PR is aims to FIX an issues with stored "variance" operation result:
It seems that the result is stored in the returned dict with the key "deviation" instead of "variance".
This PR fixes it.
Signed-off-by: shimon-armis [email protected]