Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix [FutureWarning: The frame.append method is deprecated and will be removed from pandas in a future version. Use pandas.concat instead.] #247

Merged
merged 4 commits into from
Oct 20, 2022

Conversation

psujit775
Copy link
Contributor

@psujit775 psujit775 commented Aug 31, 2022

Fix [FutureWarning: The frame.append method is deprecated and will be removed from pandas in a future version. Use pandas.concat instead.]

Upstream issue: pandas-dev/pandas#35407

… removed from pandas in a future version. Use pandas.concat instead.]
@4n4nd
Copy link
Owner

4n4nd commented Aug 31, 2022

@psujit775 could you please check why the tests are failing? Maybe the pandas version needs to be updated

@psujit775
Copy link
Contributor Author

psujit775 commented Aug 31, 2022

@4n4nd updated Pipfile and requirements.txt to pandas min version >=1.4.0.

Deprecations reference: https://pandas.pydata.org/docs/whatsnew/v1.4.0.html#whatsnew-140-deprecations-frame-series-append

prometheus_api_client/metric.py Outdated Show resolved Hide resolved
prometheus_api_client/metric.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@chauhankaranraj chauhankaranraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once all the changes are done, would you mind squashing the commits? Otherwise it looks good to me!

/lgtm 🚀

@4n4nd
Copy link
Owner

4n4nd commented Oct 20, 2022

@psujit775 could you also update the piplock?

@psujit775
Copy link
Contributor Author

@4n4nd updated the Pipfile.lock file.

@4n4nd 4n4nd merged commit 3bda292 into 4n4nd:master Oct 20, 2022
@4n4nd
Copy link
Owner

4n4nd commented Oct 20, 2022

Thanks!

@psujit775
Copy link
Contributor Author

psujit775 commented Oct 20, 2022 via email

@4n4nd
Copy link
Owner

4n4nd commented Oct 20, 2022

Thank you for working on it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants