Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all Shiny apps have the same theme #236

Merged
merged 5 commits into from
Nov 1, 2023
Merged

Conversation

gareth-j
Copy link
Contributor

@gareth-j gareth-j commented Nov 1, 2023

  • Summary of changes (Bug fix, feature, docs update, ...)

Sets the cosmo theme and same UI for all the Shiny apps.

  • Please check if the PR fulfills these requirements
  • Added an entry in the latest CHANGELOG.md file if fixing a bug or adding a new feature

@gareth-j gareth-j added the enhancement New feature or request label Nov 1, 2023
@gareth-j gareth-j self-assigned this Nov 1, 2023
Copy link
Contributor

@XueqingYin XueqingYin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @gareth-j.

Do we discard the Check mesh button? I just noticed the code shiny::actionButton("check_button", "Check mesh") was commented out.

@gareth-j
Copy link
Contributor Author

gareth-j commented Nov 1, 2023

Looks great, thanks @gareth-j.

Do we discard the Check mesh button? I just noticed the code shiny::actionButton("check_button", "Check mesh") was commented out.

Yeah that function didn't really do anything useful so I just removed it for now.

@gareth-j gareth-j merged commit c965209 into devel Nov 1, 2023
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants