-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cross scala 3 #645
Cross scala 3 #645
Conversation
Codecov Report
@@ Coverage Diff @@
## main #645 +/- ##
==========================================
+ Coverage 98.85% 99.46% +0.61%
==========================================
Files 14 18 +4
Lines 87 187 +100
Branches 7 5 -2
==========================================
+ Hits 86 186 +100
Misses 1 1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
dd9d985
to
ebeb25e
Compare
The doobie |
Pending to improve the build.sbt |
54be757
to
e5a5ae4
Compare
fde4cd1
to
c8abcb7
Compare
4ba5ff4
to
7e573af
Compare
@gutiory this is ready for review. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Astonishing work @fedefernandez!. I've just left a minor comment.
Co-authored-by: Jose Gutiérrez de Ory <[email protected]>
@gutiory I've applied your changes. I'm not sure why the patch is complaining, but the changes look good to me. Could you please review it again? |
Overview
This PR brings cross-compilation with Scala 3 to memeid. The trickiest part was the memeid4s-literal, where a new Scala 3 macro was implemented.
I've also added the
sbt-projectmatrix
plugin and re-configured the modules. The main purpose is to be able to maintain different modules with differentcrossScalaVersions
.Caveats
Some caveats from the current upgrade: