Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scala to 2.12.17 and sbt-coverage to 2.0.4 #593

Merged
merged 3 commits into from
Oct 3, 2022

Conversation

javimartinez
Copy link
Contributor

@javimartinez javimartinez commented Sep 26, 2022

@javimartinez javimartinez marked this pull request as draft September 26, 2022 14:00
@javimartinez javimartinez changed the title Update scala to 2.12.17 and sbt-coverage to 2.0.5 Update scala to 2.12.17 and sbt-coverage to 2.0. Sep 26, 2022
@javimartinez javimartinez changed the title Update scala to 2.12.17 and sbt-coverage to 2.0. Update scala to 2.12.17 and sbt-coverage to 2.0.4 Sep 26, 2022
@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Merging #593 (8f44dcc) into main (0b5fea6) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #593      +/-   ##
==========================================
+ Coverage   98.83%   98.85%   +0.01%     
==========================================
  Files          14       14              
  Lines          86       87       +1     
  Branches        1        6       +5     
==========================================
+ Hits           85       86       +1     
  Misses          1        1              
Impacted Files Coverage Δ
...-cats/src/main/scala/memeid4s/cats/instances.scala 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@javimartinez javimartinez marked this pull request as ready for review September 26, 2022 14:12
Copy link
Contributor

@fedefernandez fedefernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fedefernandez fedefernandez merged commit f89577c into main Oct 3, 2022
@fedefernandez fedefernandez deleted the update-scala-scoverage branch October 3, 2022 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants