Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to CE 3 #457

Merged
merged 15 commits into from
Nov 10, 2021
Merged

Update to CE 3 #457

merged 15 commits into from
Nov 10, 2021

Conversation

fedefernandez
Copy link
Contributor

@fedefernandez fedefernandez commented Sep 21, 2021 •
edited
Loading

Bumps to cats-effect 3

@fedefernandez fedefernandez mentioned this pull request Sep 21, 2021
Closed
@fedefernandez fedefernandez added the breaking-change A breaking change that needs to be treated with consideration label Sep 21, 2021
@codecov
Copy link

codecov bot commented Sep 21, 2021 •
edited
Loading

Codecov Report

Merging #457 (7539398) into main (7393a68) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #457      +/-   ##
==========================================
+ Coverage   98.82%   98.83%   +0.01%     
==========================================
  Files          14       14              
  Lines          85       86       +1     
  Branches        1        1              
==========================================
+ Hits           84       85       +1     
  Misses          1        1
Impacted Files Coverage Δ
...d4s-cats/src/main/scala/memeid4s/cats/syntax.scala 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7393a68...7539398. Read the comment docs.

@fedefernandez fedefernandez marked this pull request as ready for review September 21, 2021 18:10
@fedefernandez fedefernandez marked this pull request as draft September 21, 2021 18:10
@fedefernandez fedefernandez mentioned this pull request Sep 22, 2021
Closed
@fedefernandez fedefernandez marked this pull request as ready for review October 25, 2021 10:30
@fedefernandez
Copy link
Contributor Author

Should we release a Mx or RCx version?

@gutiory
Copy link
Contributor

gutiory commented Oct 27, 2021 •
edited
Loading

I think that a RC would be fine. We can test for a while and see that no bugs are found. Thanks @fedefernandez!

@fedefernandez fedefernandez merged commit 588255a into main Nov 10, 2021
@fedefernandez fedefernandez deleted the update/cats-effect-3 branch November 10, 2021 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gutiory gutiory gutiory approved these changes

@alejandrohdezma alejandrohdezma alejandrohdezma approved these changes

Assignees
No one assigned
Labels
breaking-change A breaking change that needs to be treated with consideration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fedefernandez @gutiory @alejandrohdezma @47erbot