Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tapir-core to 0.17.19 #354

Merged
merged 1 commit into from
Apr 23, 2021
Merged

Update tapir-core to 0.17.19 #354

merged 1 commit into from
Apr 23, 2021

Conversation

megankelly
Copy link
Contributor

@megankelly megankelly commented Apr 22, 2021

Currently all update PRs from the 47erbot are failing with compile errors (copied below) that are coming from breaking changes in the prerelease versions of tapir. In order to avoid pulling that in, I am setting tapir-core to "0.17.19" and putting it under the scala-steward:on section.

[error] /home/runner/work/memeid/memeid/modules/memeid4s-tapir/src/main/scala/memeid4s/tapir/instances.scala:19:8: value modifySchema is not a member of sttp.tapir.Codec[String,memeid4s.UUID,sttp.tapir.CodecFormat.TextPlain]
[error] possible cause: maybe a semicolon is missing before `value modifySchema`?
[error]       .modifySchema(_.format("uuid"))
[error]        ^
[error] /home/runner/work/memeid/memeid/modules/memeid4s-tapir/src/main/scala/memeid4s/tapir/instances.scala:24:50: type mismatch;
[error]  found   : sttp.tapir.SchemaType.SString.type
[error]  required: sttp.tapir.SchemaType[?]
[error]   implicit val UUIDSchema: Schema[UUID] = Schema(SString).format("uuid")
[error]                                                  ^
[error] two errors found

@github-actions github-actions bot added the scala-steward Dependency auto updates created by scala-steward label Apr 22, 2021
@codecov
Copy link

codecov bot commented Apr 22, 2021

Codecov Report

Merging #354 (c2f97ce) into main (e3f37b7) will not change coverage.
The diff coverage is n/a.

❗ Current head c2f97ce differs from pull request most recent head a70eaea. Consider uploading reports for the commit a70eaea to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #354   +/-   ##
=======================================
  Coverage   98.82%   98.82%           
=======================================
  Files          14       14           
  Lines          85       85           
  Branches        1        1           
=======================================
  Hits           84       84           
  Misses          1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3f37b7...a70eaea. Read the comment docs.

@megankelly megankelly marked this pull request as ready for review April 22, 2021 18:26
Copy link
Member

@juanpedromoreno juanpedromoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @megankelly

Copy link
Contributor

@gutiory gutiory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one @megankelly!!

@megankelly megankelly merged commit 2ec4744 into main Apr 23, 2021
@megankelly megankelly deleted the update/tapir-core-0.17.19 branch April 23, 2021 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scala-steward Dependency auto updates created by scala-steward
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants