Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compile regex statically in fromString #136

Merged
merged 2 commits into from
Mar 9, 2020
Merged

Compile regex statically in fromString #136

merged 2 commits into from
Mar 9, 2020

Conversation

purrgrammer
Copy link
Contributor

Based on #135

Thanks to @Philippus for your contribution!

@alejandrohdezma alejandrohdezma mentioned this pull request Mar 9, 2020
Merged
@alejandrohdezma alejandrohdezma linked an issue Mar 9, 2020 that may be closed by this pull request
fromString method accepts invalid strings #134
Closed
@alejandrohdezma alejandrohdezma changed the title Validate string in constructor Compile regex statically in fromString Mar 9, 2020
@alejandrohdezma alejandrohdezma added the enhancement New feature or request label Mar 9, 2020
@alejandrohdezma alejandrohdezma merged commit 268dd12 into master Mar 9, 2020
@alejandrohdezma alejandrohdezma deleted the validate-string branch March 9, 2020 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenFradet BenFradet BenFradet approved these changes

@gutiory gutiory gutiory approved these changes

@alejandrohdezma alejandrohdezma alejandrohdezma approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fromString method accepts invalid strings
4 participants
@purrgrammer @BenFradet @gutiory @alejandrohdezma