Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vk: Remove GroupID #1668

Merged
merged 1 commit into from
Jan 9, 2022
Merged

vk: Remove GroupID #1668

merged 1 commit into from
Jan 9, 2022

Conversation

SevereCloud
Copy link
Contributor

  • using longpoll.NewLongPollCommunity(vk *api.VK) instead longpoll.NewLongPoll(vk *api.VK, groupID int)
  • add lp.Shutdown() for Disconnect()

@codeclimate
Copy link

codeclimate bot commented Dec 30, 2021

Code Climate has analyzed commit f7a5609 and detected 0 issues on this pull request.

View more on Code Climate.

@42wim
Copy link
Owner

42wim commented Jan 9, 2022

Thanks for this PR, could you give a reason why the group ID needs to be removed? (I'm not using VK myself)
Is this not longer used or being autodetected?

@SevereCloud
Copy link
Contributor Author

Being autodetected

@42wim 42wim added this to the 1.24.0 milestone Jan 9, 2022
@42wim 42wim merged commit 16ab4c6 into 42wim:master Jan 9, 2022
@42wim
Copy link
Owner

42wim commented Jan 9, 2022

Thanks!

@SevereCloud SevereCloud deleted the vk-remove-groupid branch January 9, 2022 21:51
@42wim 42wim added the vk label Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
vk
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SevereCloud @42wim