-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Harmony #1656
Add support for Harmony #1656
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 38031 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 38031 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 38031 lines exceeds the maximum allowed for the inline comments feature.
Thank you for the PR, could you fix the linter issue, just Is there a test harmony chat server available somewhere? |
6f22adc
to
9af5c0f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 29568 lines exceeds the maximum allowed for the inline comments feature.
okay. btw, can i ask what's up with the xmpp dependency? it's making developing on matterbridge near impossible since i need to surgically update the go.mod, go.sum, vendor/modules.txt, and vendored packages myself since the referenced commit isn't valid and only exists in the vendored copy matterbridge has. |
9af5c0f
to
2117a3b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 29574 lines exceeds the maximum allowed for the inline comments feature.
2117a3b
to
164cf0f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 29590 lines exceeds the maximum allowed for the inline comments feature.
added example to .sample |
That's fixed now with PR #1661 , you'll have to rebase for the |
164cf0f
to
9fe790b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 29592 lines exceeds the maximum allowed for the inline comments feature.
9fe790b
to
b5d8d4e
Compare
thanks! that'll make stuff much easier to hack on. rebased the branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 29628 lines exceeds the maximum allowed for the inline comments feature.
Harmony is a relatively new (1,5yo) chat protocol with a small community. This introduces support for Harmony into Matterbridge, using the functionality specifically designed for bridge bots. The implementation is a modest 200 lines of code.
b5d8d4e
to
617a0d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 29626 lines exceeds the maximum allowed for the inline comments feature.
Code Climate has analyzed commit 617a0d0 and detected 0 issues on this pull request. View more on Code Climate. |
🚀 thanks! |
Thanks! Added a wiki page for Harmony configuration now :) |
@pontaoski thanks, appreciated! |
Harmony is a relatively new (1,5yo) chat protocol with a small community.
This introduces support for Harmony into Matterbridge, using the functionality
specifically designed for bridge bots. The implementation is a modest 200 lines
of code.