Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Harmony #1656

Merged
merged 1 commit into from
Dec 18, 2021
Merged

Add support for Harmony #1656

merged 1 commit into from
Dec 18, 2021

Conversation

pontaoski
Copy link
Contributor

Harmony is a relatively new (1,5yo) chat protocol with a small community.
This introduces support for Harmony into Matterbridge, using the functionality
specifically designed for bridge bots. The implementation is a modest 200 lines
of code.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 38031 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 38031 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 38031 lines exceeds the maximum allowed for the inline comments feature.

@42wim
Copy link
Owner

42wim commented Dec 10, 2021

Thank you for the PR, could you fix the linter issue, just gofumpt -w -s the file.
Can you also extend the https://github.com/42wim/matterbridge/blob/master/matterbridge.toml.sample file with your bridge documentation ? (and if possible the wiki https://github.com/42wim/matterbridge/wiki too).

Is there a test harmony chat server available somewhere?

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 29568 lines exceeds the maximum allowed for the inline comments feature.

@pontaoski
Copy link
Contributor Author

okay.

btw, can i ask what's up with the xmpp dependency? it's making developing on matterbridge near impossible since i need to surgically update the go.mod, go.sum, vendor/modules.txt, and vendored packages myself since the referenced commit isn't valid and only exists in the vendored copy matterbridge has.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 29574 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 29590 lines exceeds the maximum allowed for the inline comments feature.

@pontaoski
Copy link
Contributor Author

added example to .sample

@42wim
Copy link
Owner

42wim commented Dec 12, 2021

btw, can i ask what's up with the xmpp dependency? it's making developing on matterbridge near impossible since i need to surgically update the go.mod, go.sum, vendor/modules.txt, and vendored packages myself since the referenced commit isn't valid and only exists in the vendored copy matterbridge has.

That's fixed now with PR #1661 , you'll have to rebase for the go.sum though :/
(The matterbridge branch on the xmpp dependency was rebased and I forgot to update the go.mod)

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 29592 lines exceeds the maximum allowed for the inline comments feature.

@pontaoski
Copy link
Contributor Author

btw, can i ask what's up with the xmpp dependency? it's making developing on matterbridge near impossible since i need to surgically update the go.mod, go.sum, vendor/modules.txt, and vendored packages myself since the referenced commit isn't valid and only exists in the vendored copy matterbridge has.

That's fixed now with PR #1661 , you'll have to rebase for the go.sum though :/ (The matterbridge branch on the xmpp dependency was rebased and I forgot to update the go.mod)

thanks! that'll make stuff much easier to hack on.

rebased the branch.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 29628 lines exceeds the maximum allowed for the inline comments feature.

Harmony is a relatively new (1,5yo) chat protocol with a small community.
This introduces support for Harmony into Matterbridge, using the functionality
specifically designed for bridge bots. The implementation is a modest 200 lines
of code.
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 29626 lines exceeds the maximum allowed for the inline comments feature.

@codeclimate
Copy link

codeclimate bot commented Dec 13, 2021

Code Climate has analyzed commit 617a0d0 and detected 0 issues on this pull request.

View more on Code Climate.

@42wim 42wim added this to the 1.24.0 milestone Dec 18, 2021
@42wim 42wim added the harmony label Dec 18, 2021
@42wim 42wim merged commit dbedc99 into 42wim:master Dec 18, 2021
@42wim
Copy link
Owner

42wim commented Dec 18, 2021

🚀 thanks!

@pontaoski
Copy link
Contributor Author

Thanks!

Added a wiki page for Harmony configuration now :)

@42wim
Copy link
Owner

42wim commented Dec 18, 2021

@pontaoski thanks, appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants