Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Option to automatically convert webp files #398

Closed
TomTheDragon opened this issue Mar 29, 2018 · 6 comments
Closed

[Feature] Option to automatically convert webp files #398

TomTheDragon opened this issue Mar 29, 2018 · 6 comments
Labels
enhancement New feature or request waiting for feedback Further information is requested
Milestone
1.14.0

Comments

@TomTheDragon
Copy link

TomTheDragon commented Mar 29, 2018 •
edited
Loading

Would be nice to have a option to automatically convert webp (common on Telegram) files to more common file formats before uploading them to the mediaserver/other bridged networks (like Discord). Because its nice to be able to see stuff like stickers on networks like IRC but youre then presented with a webp file, which is still a really uncommon file format + Discord for example usually wants to block them.
@42wim 42wim added the enhancement New feature or request label Apr 1, 2018
@42wim
Copy link
Owner

42wim commented Apr 1, 2018

What format should it convert too ?

@TomTheDragon
Copy link
Author

PNG would be the best option with the least loss in quality and it also supports the transparent that's used in Telegram stickers for example but JPG would be nice as well, to save some space.
I guess the best way to do it, would be to add an option to choose between none, PNG and JPG.

@TomTheDragon
Copy link
Author

Any news to this? It would also help reducing the storage requirement of the media server, since stickers could then (in PNG form) directly uploaded to networks like Discord.

@42wim
Copy link
Owner

42wim commented Feb 21, 2019

No, not yet. But this feature request may resolve it self as all the major browsers are going to support it (https://www.cnet.com/news/firefox-to-support-googles-webp-image-format-for-a-faster-web/) and discord probably will support it too.

@TomTheDragon
Copy link
Author

Browser support will get better yes but this is not really a solution to this problem.
Could something like maybe help? https://github.com/pennello/go_webp2png

@42wim 42wim added this to the 1.14.0 milestone Feb 26, 2019
42wim added a commit that referenced this issue Feb 26, 2019
@42wim
Add MediaConvertWebPToPNG option (telegram).
b793199 
When enabled matterbridge will convert .webp files to .png files
before uploading them to the mediaserver of the other bridges.

Fixes #398
42wim added a commit that referenced this issue Feb 26, 2019
@42wim
Add MediaConvertWebPToPNG option (telegram).
948e8e2 
When enabled matterbridge will convert .webp files to .png files
before uploading them to the mediaserver of the other bridges.

Fixes #398
@42wim 42wim mentioned this issue Feb 26, 2019
Merged
@42wim
Copy link
Owner

42wim commented Feb 26, 2019

It has been added in a PR, could you test https://bintray.com/42wim/nightly/Matterbridge/v1.14.0-rc1-7-gd44d2a5#files ? and give feedback?

@42wim 42wim added the waiting for feedback Further information is requested label Feb 26, 2019
42wim added a commit that referenced this issue Feb 26, 2019
@42wim
Add MediaConvertWebPToPNG option (telegram). (#741)
26a7e35 
* Add MediaConvertWebPToPNG option (telegram).

When enabled matterbridge will convert .webp files to .png files
before uploading them to the mediaserver of the other bridges.

Fixes #398
zeridon pushed a commit to zeridon/matterbridge that referenced this issue Feb 12, 2020
@42wim @zeridon
Add MediaConvertWebPToPNG option (telegram). (42wim#741)
ed26513 
* Add MediaConvertWebPToPNG option (telegram).

When enabled matterbridge will convert .webp files to .png files
before uploading them to the mediaserver of the other bridges.

Fixes 42wim#398
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request waiting for feedback Further information is requested
Projects
None yet
Milestone
1.14.0
Development

No branches or pull requests
2 participants
@42wim @TomTheDragon