-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slack -> Discord Deleting message with an image does not work. #1705
Comments
noisymime
changed the title
Slick->Discord Deleting message with an image does not work.
Slack -> Discord Deleting message with an image does not work.
Feb 2, 2022
42wim
added a commit
that referenced
this issue
Feb 4, 2022
We create a new event EventFileDelete which will be used to delete specific uploaded files using the Extra["file"] in the config.Message. We also add a new NativeID key to the FileInfo struct which will contain the native file ID of the sending bridge. When a new file is added to the config.Message.Extra["file"] map, now the bridge native file ID should be added here. When the receiving bridge receives such a message, it should keep an internal mapping of NativeID <> bridge fileid/message id. In the case of discord we map it to the resulted discord message ID after uploading it. Now when a bridge deletes a file, it should send a EventFileDelete and setting the ID to the native file ID of the bridge. When the receiving bridge will get this event it'll look into the NativeID <> bridge id mapping to find their internal ID and use it to delete the specific file on their side. For now this is implemented for slack to discord but this will be add to other bridges where useful.
42wim
added a commit
that referenced
this issue
Feb 4, 2022
We create a new event EventFileDelete which will be used to delete specific uploaded files using the Extra["file"] in the config.Message. We also add a new NativeID key to the FileInfo struct which will contain the native file ID of the sending bridge. When a new file is added to the config.Message.Extra["file"] map, now the bridge native file ID should be added here. When the receiving bridge receives such a message, it should keep an internal mapping of NativeID <> bridge fileid/message id. In the case of discord we map it to the resulted discord message ID after uploading it. Now when a bridge deletes a file, it should send a EventFileDelete and setting the ID to the native file ID of the bridge. When the receiving bridge will get this event it'll look into the NativeID <> bridge id mapping to find their internal ID and use it to delete the specific file on their side. For now this is implemented for slack to discord but this will be add to other bridges where useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
A message created in Slack is bridged through to Discord OK. Deleting that message in Slack will delete the msg in Discord, however not when the original message contains an image.
To Reproduce
Expected behavior
Messages containing images should be deleted, just like messages containing no images.
Screenshots/debug logs
Debug log when deleting a message containing an image.
One thing I've noted is that on the final line there is
ID:""
. When performing a deletion on a message that does not contain an image, thisID
value contains the msg ID, however this appears to be missing when the original msg contains an image.Environment (please complete the following information):
Additional context
Config:
The text was updated successfully, but these errors were encountered: